[ 
https://issues.apache.org/jira/browse/FLUME-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498336#comment-14498336
 ] 

Hari Shreedharan commented on FLUME-2619:
-----------------------------------------

Why do you need this change:
{code}
if (t instanceof ChannelException) {
  throw (ChannelException)t;
}
{code}

ChannelException is unchecked, so you don't need that cast. I don't see any 
benefit of doing this, since a catch for ChannelException will catch it even 
without the cast here. Am I missing something?

> Spooldir source does not log channel exceptions
> -----------------------------------------------
>
>                 Key: FLUME-2619
>                 URL: https://issues.apache.org/jira/browse/FLUME-2619
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>            Reporter: Santiago M. Mola
>            Assignee: Johny Rufus
>             Fix For: 1.6
>
>         Attachments: FLUME-2619-1.patch, FLUME-2619.patch
>
>
> Spooldir assumes that any ChannelException means that the channel is full and 
> it does not log the exception message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to