----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39035/#review101651 -----------------------------------------------------------
Looks reasonable to me, just one comment: flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java (line 86) <https://reviews.apache.org/r/39035/#comment159101> Shouldn't we document the new configuration option? Jarcec - Jarek Cecho On Oct. 6, 2015, 1:30 a.m., Johny Rufus John wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39035/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 1:30 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-2712 > https://issues.apache.org/jira/browse/FLUME-2712 > > > Repository: flume-git > > > Description > ------- > > Optional channel errors slows down the Source to Main channel event rate. > This change makes delivery to optional channel asynchronously. > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java > 1cce137 > > Diff: https://reviews.apache.org/r/39035/diff/ > > > Testing > ------- > > Tested with optional channel setup to observe the performance improvement > > > Thanks, > > Johny Rufus John > >
