[
https://issues.apache.org/jira/browse/FLUME-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981879#comment-14981879
]
Hari Shreedharan commented on FLUME-2712:
-----------------------------------------
Johny,
This looks good in general. Some minor comments:
* I think the {{executeRequiredChannelTransaction}} can be
{{executeChannelTransaction}} and can be used for both. Just take an additional
flag as an argument and throw the {{ChannelException}} based on that. Otherwise
the run method in {{OptionalChannelTransactionExecutor}} are exactly the same
* {{OptionalChannelTransactionExecutor}} should be named
{{OptionalChannelTransactionThread}} or something like that - it really is not
an executor.
* {{List<Event> events = new ArrayList<Event>()}} -> {{List<Event> events = new
ArrayList<Event>(1)}} in {{processEvent}} method.
> Optional channel errors slows down the Source to Main channel event rate
> ------------------------------------------------------------------------
>
> Key: FLUME-2712
> URL: https://issues.apache.org/jira/browse/FLUME-2712
> Project: Flume
> Issue Type: Bug
> Reporter: Johny Rufus
> Assignee: Johny Rufus
> Attachments: FLUME-2712-1.patch, FLUME-2712.patch, FLUME-2712.patch
>
>
> When we have a source configured to deliver events to a main channel and an
> optional channel, and if the delivery to optional channel fails, this
> significantly slows down the rate at which events are delivered to the main
> channel by the source.
> We need to evaluate async means of delivering events to the optional channel
> and isolate the errors happening in optional channel from the delivery to the
> main channel
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
