[
https://issues.apache.org/jira/browse/FLUME-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jackey Lyu updated FLUME-2785:
------------------------------
Description:
The current implementation of thrift source in
`flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java`, there
is something can be done to improve the usability of thrift source.
If users did not config the `threads` parameter for thrift source, the default
threads number will be Integer.MAX_VALUE, which may easily cause
OutofMemoryError if no threads are in idle status.
It's better to add a non-zero default value for it.
And in the manual https://flume.apache.org/FlumeUserGuide.html#thrift-source,
the `threads` parameter is not required, I think it is better to notice that it
is required.
was:
The current implementation of thrift source in
`flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java`, there
is something can be done to improve the usability of thrift source.
If users did not config the `threads` parameter for thrift source, the default
threads number will be Integer.MAX_VALUE, which may easily cause
OutofMemoryError.
It's better to add a non-zero default value for it.
And in the manual https://flume.apache.org/FlumeUserGuide.html#thrift-source,
the `threads` parameter is not required, which may
> Add default non-zero threads value for Thrift source, to avoid
> OutofMemoryException
> -----------------------------------------------------------------------------------
>
> Key: FLUME-2785
> URL: https://issues.apache.org/jira/browse/FLUME-2785
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.6.0
> Environment: linux_64 2.6.32.57, Oracle JDK 1.7
> Reporter: Jackey Lyu
> Priority: Minor
> Labels: patch
> Fix For: notrack
>
> Attachments:
> 0001-update-the-DEFAULT_THREADS-for-configuration-threads.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> The current implementation of thrift source in
> `flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java`,
> there is something can be done to improve the usability of thrift source.
> If users did not config the `threads` parameter for thrift source, the
> default threads number will be Integer.MAX_VALUE, which may easily cause
> OutofMemoryError if no threads are in idle status.
> It's better to add a non-zero default value for it.
> And in the manual https://flume.apache.org/FlumeUserGuide.html#thrift-source,
> the `threads` parameter is not required, I think it is better to notice that
> it is required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
