----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41529/#review111044 -----------------------------------------------------------
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java (line 267) <https://reviews.apache.org/r/41529/#comment171035> the comment isn't needed flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java (line 302) <https://reviews.apache.org/r/41529/#comment171036> There should be a array size check at line 282. Also we don't want to check for 2181. ZooKeeper may have different ports because it can be configured to anything. What we want to do is if the array on line 282 is length 0 then on like 293 we want to set it to 2181. flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java (line 309) <https://reviews.apache.org/r/41529/#comment171040> We need to suround the whole parsing block with a try catch block that says. Malformed zkQuorum value. flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java (line 77) <https://reviews.apache.org/r/41529/#comment171039> Don't need this comment - Ted Malaska On Dec. 17, 2015, 8:33 p.m., Sam Glover wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41529/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 8:33 p.m.) > > > Review request for Flume and Ted Malaska. > > > Repository: flume-git > > > Description > ------- > > FLUME-2858, Added better exception message for malformed zookeeperQuorum. > Added default port 2181 if the zookeeperQuorum port is not given. > > > Diffs > ----- > > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java > e659ada > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java > 5560624 > > Diff: https://reviews.apache.org/r/41529/diff/ > > > Testing > ------- > > Yes. Ran mvn clean install with no issues, no failures. > > > Thanks, > > Sam Glover > >
