See https://cwiki.apache.org/confluence/display/FLUME/How+to+Contribute <https://cwiki.apache.org/confluence/display/FLUME/How+to+Contribute>
Ralph > On Feb 4, 2016, at 7:10 AM, Pushkar Raste <[email protected]> wrote: > > Well not yet. I did not find any documentation around it. How can I create > s review request? > > -- Pushkar Raste > On Feb 4, 2016 9:08 AM, "Ralph Goers" <[email protected]> wrote: > >> Did you create a review request in ReviewBoard? >> >> Ralph >> >>> On Feb 4, 2016, at 6:44 AM, Pushkar Raste <[email protected]> >> wrote: >>> >>> If that is the case can you commit my patch for 2856 as well :-) >>> >>> Its been months and no one has commented on it yet >>> >>> -- Pushkar Raste >>> Out of curiosity, is there a 72hr rule that says if no one bothers to >> look >>> at the review I can just go ahead and commit it? >>> >>> Ralph >>> >>>> On Feb 2, 2016, at 11:01 PM, Ralph Goers <[email protected]> wrote: >>>> >>>> >>>> ----------------------------------------------------------- >>>> This is an automatically generated e-mail. To reply, visit: >>>> https://reviews.apache.org/r/43100/ >>>> ----------------------------------------------------------- >>>> >>>> (Updated Feb. 3, 2016, 6:01 a.m.) >>>> >>>> >>>> Review request for Flume. >>>> >>>> >>>> Changes >>>> ------- >>>> >>>> Add changes to the users guide >>>> >>>> >>>> Repository: flume-git >>>> >>>> >>>> Description >>>> ------- >>>> >>>> Patch for FLUME-2875 - Allows custom PathManagers and allows a file >>> prefix and extension in the default PathManager for the RollingFileSink >>>> >>>> >>>> Diffs (updated) >>>> ----- >>>> >>>> >>> >> flume-ng-core/src/main/java/org/apache/flume/formatter/output/DefaultPathManager.java >>> PRE-CREATION >>>> >>> >> flume-ng-core/src/main/java/org/apache/flume/formatter/output/PathManager.java >>> 933cc94 >>>> >>> >> flume-ng-core/src/main/java/org/apache/flume/formatter/output/PathManagerFactory.java >>> PRE-CREATION >>>> >>> >> flume-ng-core/src/main/java/org/apache/flume/formatter/output/PathManagerType.java >>> PRE-CREATION >>>> flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java >>> 9cb3370 >>>> >>> >> flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java >>> 07fa644 >>>> flume-ng-doc/sphinx/FlumeUserGuide.rst 0f8461d >>>> >>>> Diff: https://reviews.apache.org/r/43100/diff/ >>>> >>>> >>>> Testing >>>> ------- >>>> >>>> >>>> Thanks, >>>> >>>> Ralph Goers >>>> >> >> >>
