[
https://issues.apache.org/jira/browse/FLUME-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169995#comment-15169995
]
Roshan Naik edited comment on FLUME-2889 at 2/26/16 10:43 PM:
--------------------------------------------------------------
Thanks [~tmgstev] for catching that.
I am revising the patch with the same fix applied to
SyslogAvroEventSerializer.java.
Not sure why there is duplication of logic.
Since short on time (feb 26 already) i wont try to attempt to merge the two
code pieces and upload another fix.
Can you please review this v3 patch ?
was (Author: roshan_naik):
Thanks [~tmgstev] for catching that.
I am revising the patch with the same fix applied to
SyslogAvroEventSerializer.java.
Not sure why there is duplication of logic.
Since short on time (feb 26 already) i wont try to attempt to merge the two
code pieces and upload another fix.
Can you please review this v4 patch ?
> Fixes to DateTime computations
> -------------------------------
>
> Key: FLUME-2889
> URL: https://issues.apache.org/jira/browse/FLUME-2889
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.6.0
> Reporter: Roshan Naik
> Assignee: Roshan Naik
> Fix For: v1.7.0
>
> Attachments: FLUME-2889-2.patch, FLUME-2889.3.patch, FLUME-2889.patch
>
>
> date.withYear(year+1) can lead to incorrect date calculations .. for example
> if the date is Feb 29th. need to use date.plusYears(1) instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
