[
https://issues.apache.org/jira/browse/FLUME-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170096#comment-15170096
]
Roshan Naik commented on FLUME-2889:
------------------------------------
Yes will wait for Tristan.
Trying to assess the impact this bug has on flume users. Could use some inputs
here .. My assessment is below :
1) SyslogAvroEventSerializer.java: Here it could cause bad data to be written
out to the file
2) SyslogParser.java : This looks like will apply a bad date in the timestamp
header. That could then either end up causing events to go down the wrong
destination if that header is used to determine the destination... or even bad
data .. if the header value is somehow during serialization
3) In both cases is the problem limited to adjusting leap year dates (Feb 29)
only ? would be nice to see an example showing the problem.
Thanks
> Fixes to DateTime computations
> -------------------------------
>
> Key: FLUME-2889
> URL: https://issues.apache.org/jira/browse/FLUME-2889
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.6.0
> Reporter: Roshan Naik
> Assignee: Roshan Naik
> Fix For: v1.7.0
>
> Attachments: FLUME-2889-2.patch, FLUME-2889.3.patch, FLUME-2889.patch
>
>
> date.withYear(year+1) can lead to incorrect date calculations .. for example
> if the date is Feb 29th. need to use date.plusYears(1) instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
