[ 
https://issues.apache.org/jira/browse/FLUME-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332580#comment-15332580
 ] 

Mike Percy commented on FLUME-2923:
-----------------------------------

[~bessbd]: Did you run the asynchbase unit tests after applying this patch?

I get a bunch of failures. Are you seeing the same thing?

{code}
mpercy@mpercy-ThinkPad-T530:~/src/flume$ git log --oneline -n5
ee4999b FLUME-2910. AsyncHBaseSink: Failure callbacks should log the exception 
that caused them
f46bee0 FLUME-2920: Kafka Channel Should Not Commit Offsets When Stopping
a619cc1 FLUME-2915: The kafka channel using new APIs will be stuck when the 
sink is avro sink
f4f15be FLUME-2913. Don't strip SLF4J from imported classpaths
37ddd1b FLUME-2909. Upgrade RAT to 0.11
{code}

{code}
mpercy@mpercy-ThinkPad-T530:~/src/flume$ git diff
diff --git a/pom.xml b/pom.xml
index 0929095..110c216 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1292,7 +1292,7 @@ limitations under the License.
       <dependency>
         <groupId>org.hbase</groupId>
         <artifactId>asynchbase</artifactId>
-        <version>1.5.0</version>
+        <version>1.7.0</version>
         <exclusions>
           <exclusion>
             <groupId>org.slf4j</groupId>
{code}

{code}
mpercy@mpercy-ThinkPad-T530:~/src/flume$ mvn clean install -DskipTests 
-Drat.skip=true; mvn -pl flume-ng-sinks/flume-ng-hbase-sink -Drat.skip=true test
...
Results :

Tests in error:
  testMultipleBatches(org.apache.flume.sink.hbase.TestAsyncHBaseSink): 
org/jboss/netty/channel/socket/nio/BossPool
  
testMultipleBatchesBatchIncrementsWithCoalescing(org.apache.flume.sink.hbase.TestAsyncHBaseSink):
 org/jboss/netty/channel/socket/nio/BossPool
  
testMultipleBatchesBatchIncrementsNoCoalescing(org.apache.flume.sink.hbase.TestAsyncHBaseSink):
 org/jboss/netty/channel/socket/nio/BossPool
  
testWithoutConfigurationObject(org.apache.flume.sink.hbase.TestAsyncHBaseSink): 
org/jboss/netty/channel/socket/nio/BossPool
  testMissingTable(org.apache.flume.sink.hbase.TestAsyncHBaseSink): Unexpected 
exception, expected<org.apache.flume.FlumeException> but 
was<java.lang.NoClassDefFoundError>
  testFDLeakOnShutdown(org.apache.flume.sink.hbase.TestAsyncHBaseSink): 
org/jboss/netty/channel/socket/nio/BossPool
  testOneEventWithDefaults(org.apache.flume.sink.hbase.TestAsyncHBaseSink): 
org/jboss/netty/channel/socket/nio/BossPool
  testOneEvent(org.apache.flume.sink.hbase.TestAsyncHBaseSink): 
org/jboss/netty/channel/socket/nio/BossPool
  testThreeEvents(org.apache.flume.sink.hbase.TestAsyncHBaseSink): 
org/jboss/netty/channel/socket/nio/BossPool
  testTimeOut(org.apache.flume.sink.hbase.TestAsyncHBaseSink): Unexpected 
exception, expected<org.apache.flume.EventDeliveryException> but 
was<java.lang.NoClassDefFoundError>

Tests run: 31, Failures: 0, Errors: 10, Skipped: 2
{code}

Note that the above command causes all tests to pass for me on trunk without 
applying your patch.

Mike

> Bump AsyncHBase version
> -----------------------
>
>                 Key: FLUME-2923
>                 URL: https://issues.apache.org/jira/browse/FLUME-2923
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.7.0
>            Reporter: Bessenyei Balázs Donát
>            Assignee: Bessenyei Balázs Donát
>            Priority: Minor
>             Fix For: v1.7.0
>
>         Attachments: FLUME-2923.patch
>
>
> The current version of AsyncHBase ( http://opentsdb.github.io/asynchbase/ ) 
> is outdated.
> Reason for the upgrade would be many bug fixes and some new public APIs. (See 
> https://github.com/OpenTSDB/asynchbase/blob/master/NEWS )



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to