+1

On Fri, Jun 24, 2016 at 2:24 PM, Mike Percy <[email protected]> wrote:
> Hey devs,
> Code nitpicks have come up a bit lately (in code I'm the reviewer of).
> Other Apache projects such as HBase and Kafka use checkstyle to do a
> pre-commit check at build time. Rather than spend time going back and forth
> on code style, how about we adopt the checkstyle plugin for Flume?
>
>  I'd propose adopting the Google Java style. It's what the vast majority of
> the Flume code uses today, and there is a config file shipped with
> checkstyle for it. Here's a link to it:
> https://google.github.io/styleguide/javaguide.html
>
> My goal is just to maintain a consistent style throughout the code base and
> avoid the review noise. Please let me know whether or not this sounds
> helpful.
>
> Thanks,
> Mike



-- 
thanks
ashish

Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal

Reply via email to