----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49025/#review139762 -----------------------------------------------------------
flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java (line 222) <https://reviews.apache.org/r/49025/#comment205105> how about just Thread.sleep(10); 100 is a long time flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java (line 266) <https://reviews.apache.org/r/49025/#comment205104> style nit: extra line here. keep blank lines to 1 adjacent flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java (line 269) <https://reviews.apache.org/r/49025/#comment205103> style nit: indent 4 spaces here and elsewhere for a line continuation, unless you align the indentation with the previous parentheses or something like that flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java (line 287) <https://reviews.apache.org/r/49025/#comment205102> Does this loop for 30 seconds? I was thinking 300 milliseconds only... Also I don't think while (e != null) is correct, you will only loop one time. flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java (line 289) <https://reviews.apache.org/r/49025/#comment205106> How about just Thread.sleep(10) - Mike Percy On June 27, 2016, 2:28 p.m., Balázs Donát Bessenyei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49025/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 2:28 p.m.) > > > Review request for Flume, Denes Arvay, Mike Percy, and Attila Simon. > > > Repository: flume-git > > > Description > ------- > > SpoolrDir currently monitors a directory and can not handle sub-directories. > This JIRA is to make SpoolDir able to walk down a source directory and > monitor new files. > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java > d54f415 > > flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java > 3fe947d > > flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java > 5053697 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java > fe530ff > flume-ng-doc/sphinx/FlumeUserGuide.rst 74d2887 > > Diff: https://reviews.apache.org/r/49025/diff/ > > > Testing > ------- > > Ran tests before the patch: > # mvn clean install -DskipTests -Drat.skip=true; mvn -pl flume-ng-core > -Drat.skip=true test > Tests run: 378, Failures: 0, Errors: 0, Skipped: 2 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 07:55 min > [INFO] Finished at: 2016-06-21T16:13:46+02:00 > [INFO] Final Memory: 35M/510M > [INFO] > ------------------------------------------------------------------------ > > After patch: > # mvn clean install -DskipTests -Drat.skip=true; mvn -pl flume-ng-core > -Drat.skip=true test > Tests run: 380, Failures: 0, Errors: 0, Skipped: 2 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 06:18 min > [INFO] Finished at: 2016-06-21T17:04:17+02:00 > [INFO] Final Memory: 35M/511M > [INFO] > ------------------------------------------------------------------------ > > Patch also includes docs > > > Thanks, > > Balázs Donát Bessenyei > >
