Lior Zeno created FLUME-2950:
--------------------------------
Summary: ReliableSpoolingFileEventReader.rollCurrentFile is broken
Key: FLUME-2950
URL: https://issues.apache.org/jira/browse/FLUME-2950
Project: Flume
Issue Type: Bug
Affects Versions: v1.7.0
Reporter: Lior Zeno
Fix For: v1.7.0
FLUME-2939 introduced Java 7 API (nio.file) to ReliableSpoolingFileEventReader.
However, the committed patch breaks rollCurrentFile on Windows machines.
File rename might be not atomic, in such cases, and under the assumption that
the rolled file and the current file store the same data, Flume only logs a
warning and does not assume that the user broke the contract that the spooling
directory source demands.
In order to determine whether the files store the same data, we used the
com.google.common.io.Files.equal method. However, FLUME-2939 uses
java.nio.file.Files.isSameFile which has different semantics.
Consequently, this relaxation does not hold anymore. In addition,
org.apache.flume.client.avro.TestSpoolingFileLineReader.testDestinationExistsAndSameFileWindows
fails.
I attach a patch that brings back the old check for Files.equal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
