-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39545/#review142852
-----------------------------------------------------------


Ship it!




I have a couple minor suggestions, mostly around docs formatting. I am going to 
make those tweaks on commit.

- Mike Percy


On July 15, 2016, 8:23 p.m., Jeff Holoman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39545/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 8:23 p.m.)
> 
> 
> Review request for Flume and Ted Malaska.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> This patch adds the ability to specify a static schema URL in the HDFS sink 
> configuration when using the AvroEvent serialzer. 
> 
> This static URL config is evaluated only if the header options are null, thus 
> the config setting can be overridden by specifying a different schema in the 
> event header.
> 
> 
> Diffs
> -----
> 
>   
> flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventSerializerConfigurationConstants.java
>  cce67166f270bc7e4134f4aa577e1a01e88d409d 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 
> 9c11fe6235893a5221ac930fd4d91518975b5dae 
>   
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/AvroEventSerializer.java
>  fea62188a996a65a3467dc34c3936f82251912df 
>   
> flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestAvroEventSerializer.java
>  38af74d1d122da272cf046d3e52d39d6aa0e6c2a 
> 
> Diff: https://reviews.apache.org/r/39545/diff/
> 
> 
> Testing
> -------
> 
> Added additonal unit test for static URL
> 
> 
> Thanks,
> 
> Jeff Holoman
> 
>

Reply via email to