[
https://issues.apache.org/jira/browse/FLUME-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385576#comment-15385576
]
Bessenyei Balázs Donát commented on FLUME-2573:
-----------------------------------------------
[~gsbiju]: can you please explain why this change is exactly needed? Some
elaboration on the "The latter is a cleaner approach but will have impact on `
big-top `." would be super helpful.
Otherwise if the patch is applied in its current form, it breaks all current
systems where people use the -f (config file) with absolute path. As it's
passed over from the flume-ng script. (Also, the --conf command line arguments
serve different purposes in the bash script and the java program)
Collaborators: [~denes], [~sati]
> flume-ng --conf parameter is not used when starting a flume agent
> -----------------------------------------------------------------
>
> Key: FLUME-2573
> URL: https://issues.apache.org/jira/browse/FLUME-2573
> Project: Flume
> Issue Type: Bug
> Components: Node
> Affects Versions: v1.4.0
> Environment: ubuntu 12 & Flume 1.4.0
> Reporter: Biju Nair
> Labels: flume-ng
> Fix For: v1.7.0
>
> Attachments: FLUME-2573-0.patch
>
>
> flume-ng script accepts the parameter
> [conf|https://github.com/apache/flume/blob/trunk/bin/flume-ng#L183] to pass
> the directory which stores the configuration files and adds it to the
> FLUME_CLASSPATH. But
> [org.apache.flume.node.Application|https://github.com/apache/flume/blob/trunk/flume-ng-node/src/main/java/org/apache/flume/node/Application.java#L302]
> expects configuration files passed to have an absolute path. So even if user
> passes `conf` and `conf-file` option, `application` looks for the
> configuration file in the directory from which it is executed. It would be
> good to take the `conf` value into consideration so that users can place the
> config files anywhere.
> Currently big-top init.d script joins the [`conf` and `conf-file`
> values|(https://github.com/apache/flume/blob/trunk/bin/flume-ng#L183] when
> calling flume-ng. The same can be done in the ` flume-ng ` script.
> Alternatively the `conf ` parameter can be read in ` application ` and
> concatenated in the code. The latter is a cleaner approach but will have
> impact on ` big-top `.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
