----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51112/#review146677 -----------------------------------------------------------
flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java (line 251) <https://reviews.apache.org/r/51112/#comment213242> I think we need to add a test to find out what happens when multiple flume agents are part of a consumer group and they all start up concurrently. Another test to add is upgrading a single Flume node while other Flume nodes are running in Zookeeper-only mode. I am not sure we have a good way to test that with a unit test, so if we could simulate it with API calls that would be better than nothing. If it's not possible to support such a rolling upgrade, we should release-note it. - Mike Percy On Aug. 16, 2016, 12:30 p.m., Grant Henke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51112/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 12:30 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2972 > https://issues.apache.org/jira/browse/FLUME-2972 > > > Repository: flume-git > > > Description > ------- > > Offsets tracking the position in Kafka consumers change from using zookeeper > for offset storage to Kafka when moving from 0.8.x to 0.9.x. > FLUME-2823 makes the client change in the Kafka Channel but does not ensure > existing offsets get migrated in order to continue consuming where it left > off. > > This patch adds automated logic on startup to check if Kafka offsets exist, > if not and migration is enabled (by default) then the offsets from Zookeeper > are copied and committed to Kafka. > > > Diffs > ----- > > flume-ng-channels/flume-kafka-channel/pom.xml 587b4b4 > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java > 90e3288 > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannelConfiguration.java > ccf46d9 > > flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java > b63ac9b > flume-ng-doc/sphinx/FlumeUserGuide.rst fde9ff7 > > Diff: https://reviews.apache.org/r/51112/diff/ > > > Testing > ------- > > Unit tests so far. > > > Thanks, > > Grant Henke > >
