-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51491/
-----------------------------------------------------------

Review request for Flume.


Bugs: FLUME-2981
    https://issues.apache.org/jira/browse/FLUME-2981


Repository: flume-git


Description
-------

Currently flume-ng-morphline-solr-sink is using Solr 4.3.0. I propose to 
upgrade to Solr 5.5.2 for Flume 1.7.0. Also Solr 5.5.2 requires Java 1.7 same 
as Flume 1.7.0. 
Solr 5.5.2 includes guava 14 but it also works with guava 11. There were no 
problems when I confirmed it with guava 11.


Diffs
-----

  flume-ng-sinks/flume-ng-morphline-solr-sink/pom.xml 8e0bc5e 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/EmbeddedTestSolrServer.java
 PRE-CREATION 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/EnvironmentTest.java
 PRE-CREATION 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestEnvironment.java
 933a6b1 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestMorphlineSolrSink.java
 1bfae95 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/_rest_managed.json
 PRE-CREATION 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/currency.xml
 654de41 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/elevate.xml
 8f3aa80 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/contractions_ca.txt
 307a85f 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/contractions_fr.txt
 722db58 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/contractions_ga.txt
 9ebe7fa 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/contractions_it.txt
 cac0409 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/hyphenations_ga.txt
 4d2642c 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stemdict_nl.txt
 4410729 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stoptags_ja.txt
 71b7508 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_ar.txt
 046829d 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_bg.txt
 1ae4ba2 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_ca.txt
 3da65de 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_cz.txt
 53c6097 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_da.txt
 a3ff5fe 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_de.txt
 f770384 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_el.txt
 232681f 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_es.txt
 2db1476 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_eu.txt
 25f1db9 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_fa.txt
 723641c 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_fi.txt
 addad79 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_fr.txt
 c00837e 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_ga.txt
 9ff88d7 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_gl.txt
 d8760b1 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_hi.txt
 86286bb 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_hu.txt
 1a96f1d 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_hy.txt
 60c1c50 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_id.txt
 4617f83 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_it.txt
 4cb5b08 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_ja.txt
 d4321be 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_lv.txt
 e21a23c 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_nl.txt
 f4d61f5 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_no.txt
 e76f36e 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_pt.txt
 276c1b4 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_ro.txt
 4fdee90 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_ru.txt
 6430769 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_sv.txt
 22bddfd 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_th.txt
 07f0fab 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/stopwords_tr.txt
 84d9408 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/lang/userdict_ja.txt
 6f0368e 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/schema.xml
 65991e1 
  
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/resources/solr/collection1/conf/solrconfig.xml
 dc1cfc5 
  pom.xml b50693e 

Diff: https://reviews.apache.org/r/51491/diff/


Testing
-------

$ mvn clean test -pl flume-ng-sinks/flume-ng-morphline-solr-sink
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Flume NG Morphline Solr Sink 1.7.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading: 
http://repository.apache.org/snapshots/org/apache/flume/flume-ng-core/1.7.0-SNAPSHOT/maven-metadata.xml
Downloaded: 
http://repository.apache.org/snapshots/org/apache/flume/flume-ng-core/1.7.0-SNAPSHOT/maven-metadata.xml
 (782 B at 0.7 KB/sec)
Downloading: 
http://repository.apache.org/snapshots/org/apache/flume/flume-parent/1.7.0-SNAPSHOT/maven-metadata.xml
Downloaded: 
http://repository.apache.org/snapshots/org/apache/flume/flume-parent/1.7.0-SNAPSHOT/maven-metadata.xml
 (607 B at 0.8 KB/sec)
Downloading: 
http://repository.apache.org/snapshots/org/apache/flume/flume-ng-sdk/1.7.0-SNAPSHOT/maven-metadata.xml
Downloaded: 
http://repository.apache.org/snapshots/org/apache/flume/flume-ng-sdk/1.7.0-SNAPSHOT/maven-metadata.xml
 (994 B at 0.5 KB/sec)
Downloading: 
http://repository.apache.org/snapshots/org/apache/flume/flume-ng-configuration/1.7.0-SNAPSHOT/maven-metadata.xml
Downloaded: 
http://repository.apache.org/snapshots/org/apache/flume/flume-ng-configuration/1.7.0-SNAPSHOT/maven-metadata.xml
 (791 B at 1.0 KB/sec)
Downloading: 
http://repository.apache.org/snapshots/org/apache/flume/flume-ng-auth/1.7.0-SNAPSHOT/maven-metadata.xml
Downloaded: 
http://repository.apache.org/snapshots/org/apache/flume/flume-ng-auth/1.7.0-SNAPSHOT/maven-metadata.xml
 (782 B at 0.9 KB/sec)
[INFO]
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ 
flume-ng-morphline-solr-sink ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
flume-ng-morphline-solr-sink ---
[INFO] Setting property: classpath.resource.loader.class => 
'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.
[INFO] Setting property: velocimacro.messages.on => 'false'.
[INFO] Setting property: resource.loader => 'classpath'.
[INFO] Setting property: resource.manager.logwhenfound => 'false'.
Downloading: 
https://repo.maven.apache.org/maven2/org/restlet/jee/org.restlet/2.3.0/org.restlet-2.3.0.pom
Downloading: 
https://repo.maven.apache.org/maven2/ua_parser/ua-parser/1.3.0/ua-parser-1.3.0.pom
Downloading: 
https://repo.maven.apache.org/maven2/org/restlet/jee/org.restlet.ext.servlet/2.3.0/org.restlet.ext.servlet-2.3.0.pom
[INFO]
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
flume-ng-morphline-solr-sink ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/Users/minoru/git/flume/flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
flume-ng-morphline-solr-sink ---
[INFO] Compiling 8 source files to 
/Users/minoru/git/flume/flume-ng-sinks/flume-ng-morphline-solr-sink/target/classes
[INFO]
[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
flume-ng-morphline-solr-sink ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 87 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
flume-ng-morphline-solr-sink ---
[INFO] Compiling 11 source files to 
/Users/minoru/git/flume/flume-ng-sinks/flume-ng-morphline-solr-sink/target/test-classes
[INFO]
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ 
flume-ng-morphline-solr-sink ---
[INFO] Surefire report directory: 
/Users/minoru/git/flume/flume-ng-sinks/flume-ng-morphline-solr-sink/target/surefire-reports
Downloading: 
https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit4/2.12.4/surefire-junit4-2.12.4.pom
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit4/2.12.4/surefire-junit4-2.12.4.pom
 (3 KB at 9.8 KB/sec)
Downloading: 
https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-providers/2.12.4/surefire-providers-2.12.4.pom
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-providers/2.12.4/surefire-providers-2.12.4.pom
 (3 KB at 9.8 KB/sec)
Downloading: 
https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit4/2.12.4/surefire-junit4-2.12.4.jar
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire-junit4/2.12.4/surefire-junit4-2.12.4.jar
 (37 KB at 95.6 KB/sec)

-------------------------------------------------------
 T E S T S
-------------------------------------------------------

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.flume.sink.solr.morphline.TestBlobDeserializer
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.367 sec
Running org.apache.flume.sink.solr.morphline.TestBlobHandler
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.214 sec
Running org.apache.flume.sink.solr.morphline.TestEnvironment
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.149 sec
Running org.apache.flume.sink.solr.morphline.TestMorphlineInterceptor
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.014 sec
Running org.apache.flume.sink.solr.morphline.TestMorphlineSolrSink
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.112 sec
Running org.apache.flume.sink.solr.morphline.TestUUIDInterceptor
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.171 sec

Results :

Tests run: 20, Failures: 0, Errors: 0, Skipped: 0

[INFO]
[INFO] --- apache-rat-plugin:0.11:check (test.rat) @ 
flume-ng-morphline-solr-sink ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: src/test/resources/**
[INFO] 21 resources included (use -debug for more details)
Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not 
recognized.
Compiler warnings:
  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 
'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning:  org.apache.xerces.parsers.SAXParser: Feature 
'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 
'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not 
recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 21 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:01 min
[INFO] Finished at: 2016-08-29T21:55:28+09:00
[INFO] Final Memory: 78M/826M
[INFO] ------------------------------------------------------------------------


Thanks,

Minoru Osuka

Reply via email to