----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51504/#review147395 -----------------------------------------------------------
couple more comments flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java (line 453) <https://reviews.apache.org/r/51504/#comment214536> nit: please un-indent this by 2 spaces and add a single space after the // flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java (line 293) <https://reviews.apache.org/r/51504/#comment214534> Can you please try disconnecting from the internet and running this test? I am wondering if this unit test will become flaky or fail on, say, a developer laptop when they are working from the train or something. If so, we should find another solution for testing this. flume-ng-doc/sphinx/FlumeUserGuide.rst (line 1784) <https://reviews.apache.org/r/51504/#comment214539> nit: please remove the bullet point. Just say Note: - Mike Percy On Aug. 30, 2016, 5:46 p.m., Jeff Holoman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51504/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 5:46 p.m.) > > > Review request for Flume and Grant Henke. > > > Repository: flume-git > > > Description > ------- > > Added static escape strings localhost, IP and FQDN > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > f640ec9791fb6e067c20ef797691a617a8e472d6 > > flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java > ccc746066e420e772021a4bc758a81736225f76d > flume-ng-doc/sphinx/FlumeUserGuide.rst > 7e207aa825f56ea32bd5282e75ef02090b21c3f7 > > Diff: https://reviews.apache.org/r/51504/diff/ > > > Testing > ------- > > > Thanks, > > Jeff Holoman > >
