-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51802/#review149185
-----------------------------------------------------------


Ship it!




Note: I ran all the tests in flume-jms-source, it was all green.


flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java
 (lines 63 - 64)
<https://reviews.apache.org/r/51802/#comment216729>

    Is running all the tests with auth enabled and disabled really required?
    
    How about we have the already existing ones run with either enabled and 
disabled and add a new test to check the other? (Eg. run 3 tests with auth 
enabled and have a test that checks if JMS source can run with auth disabled 
too?)


- Balázs Donát Bessenyei


On Sept. 12, 2016, 1:08 p.m., Denes Arvay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51802/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 1:08 p.m.)
> 
> 
> Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila 
> Simon.
> 
> 
> Bugs: FLUME-2976
>     https://issues.apache.org/jira/browse/FLUME-2976
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> If no `userName` and `passwordFile` is set for the JMS source it sets the 
> password to `Optional("")`. This leads to an exception in the weblogic jndi 
> context implementation when trying to connect to a weblogic jms server.
> 
> 
> Diffs
> -----
> 
>   
> flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java
>  7631827 
>   
> flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java
>  53cc09a 
> 
> Diff: https://reviews.apache.org/r/51802/diff/
> 
> 
> Testing
> -------
> 
> - `flume-ng-sources/flume-jms-source` tests pass
> - `TestIntegrationActiveMQ` is now a parameterized test to test with and 
> without authentication.
> 
> 
> Thanks,
> 
> Denes Arvay
> 
>

Reply via email to