----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52216/#review150298 -----------------------------------------------------------
Do you think you could create a unit test for this fix? Like triggering an error and checking if the message is correct flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java (line 107) <https://reviews.apache.org/r/52216/#comment218203> This field seems to be never accessed. Maybe it should be removed. - Balázs Donát Bessenyei On Sept. 24, 2016, 9:54 a.m., Umesh Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52216/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2016, 9:54 a.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > Added two new booleans to identify the reason for closed channel: 1) > isClosedOnStart 2) isClosedNormally > And checked them to print the appropriate reason for closed channel > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 9d82e43 > > Diff: https://reviews.apache.org/r/52216/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Umesh Chaudhary > >
