----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52511/#review151322 -----------------------------------------------------------
Shouldn't you simply call source.close()? - Lior Zeno On Oct. 4, 2016, 11:51 a.m., Denes Arvay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52511/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 11:51 a.m.) > > > Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila > Simon. > > > Bugs: FLUME-3003 > https://issues.apache.org/jira/browse/FLUME-3003 > > > Repository: flume-git > > > Description > ------- > > The event processing in `SyslogUDPSource` is handled on a separate thread by > Netty so message delivery, thus the `sourceCounter`'s increment can be > delayed resulting in a flaky test > > > Diffs > ----- > > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java > 6ba7512 > > Diff: https://reviews.apache.org/r/52511/diff/ > > > Testing > ------- > > tests in `flume-ng-core` pass, checkstyle verification done. > > > Thanks, > > Denes Arvay > >
