[ 
https://issues.apache.org/jira/browse/FLUME-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548703#comment-15548703
 ] 

Denes Arvay commented on FLUME-2994:
------------------------------------

We only use the inode long value in the {{tailFiles}} map. If we changed the 
{{tailFiles}} to {{Map<FileKey, TailFile>}} then we could use it regardless of 
the environment. So there would be no need for platform check and - as it's not 
windows-only - I wouldn't consider that change as proliferation of a windows 
workaround. As per my understanding {{FileKey}} is a unique identifier for a 
file, so in our usecase it can replace the current inode value.

> flume-taildir-source: support for windows
> -----------------------------------------
>
>                 Key: FLUME-2994
>                 URL: https://issues.apache.org/jira/browse/FLUME-2994
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources, Windows
>    Affects Versions: v1.7.0
>            Reporter: Jason Kushmaul
>            Assignee: Jason Kushmaul
>            Priority: Trivial
>             Fix For: v1.7.0
>
>         Attachments: FLUME-2994-2.patch, taildir-mac.conf, taildir-win8.1.conf
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> The current implementation of flume-taildir-source does not support windows.
> The only reason for this from what I can see is a simple call to 
> Files.getAttribute(file.toPath(), "unix:ino");
> I've tested an equivalent for windows (which of course does not work on 
> non-windows).  With an OS switch we should be able to identify a file 
> independent of file name on either system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to