> On Oct. 21, 2016, 1:21 p.m., Attila Simon wrote: > > Ship It!
Discussed offline that there will be a follow up patch to use builder pattern for constructing BucketWriter. (So that further testing only instance mutators can be eliminated) - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52510/#review153538 ----------------------------------------------------------- On Oct. 4, 2016, 11:11 a.m., Balázs Donát Bessenyei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52510/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 11:11 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-3002 > https://issues.apache.org/jira/browse/FLUME-3002 > > > Repository: flume-git > > > Description > ------- > > testFileSuffixNotGiven (and probably a few other tests) are flaky > > > Diffs > ----- > > > c/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > b096410 > > c/flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java > 742deb0 > > Diff: https://reviews.apache.org/r/52510/diff/ > > > Testing > ------- > > mvn clean install runs successfully in flume-ng-sinks > > > Thanks, > > Balázs Donát Bessenyei > >
