[
https://issues.apache.org/jira/browse/FLUME-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612183#comment-15612183
]
Bessenyei Balázs Donát commented on FLUME-2857:
-----------------------------------------------
[~tmgstev]: The changes seem all fine, but when I was doing a last check, I've
come across an issue:
When I'm running the test for KafkaSource in debug mode, it seems to throw an
exception in the middle and never run the asserts. (Which is silent, because
there is a throws Exception on the method.)
The problem seems to be around
{noformat}String topic = findUnusedTopic();
kafkaServer.createTopic(topic, 1);{noformat}
I think, removing the parts of the test method that are not directly testing
the current change would help.
Can you please make a few changes to the patch? (Or let me know if I'm wrong.)
Thank you
PS. maybe a reviewboard request could help to discuss the code
> Kafka Source/Channel/Sink does not restore default values when live update
> config
> ---------------------------------------------------------------------------------
>
> Key: FLUME-2857
> URL: https://issues.apache.org/jira/browse/FLUME-2857
> Project: Flume
> Issue Type: Bug
> Components: Channel
> Reporter: Tristan Stevens
> Assignee: Tristan Stevens
> Attachments: FLUME-2857.patch
>
>
> Been using the following config:
> {noformat}
> tier1.channels.channel1.type = org.apache.flume.channel.kafka.KafkaChannel
> tier1.channels.channel1.capacity = 10000
> tier1.channels.channel1.transactionCapacity = 10000
> tier1.channels.channel1.brokerList =
> 10.0.0.64:9092,10.0.0.65:9092,10.0.0.66:9092
> tier1.channels.channel1.topic = flume.aggregator.channel
> tier1.channels.channel1.zookeeperConnect = 10.0.0.64:2181
> tier1.channels.channel1.kafka.producer.type=async
> tier1.channels.channel1.kafka.batch.num.messages=200
> {noformat}
> If I remove the producer.type and batch.num.messages (i.e. restore them to
> default values) when doing a live update config the new values do not take
> effect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
