[ 
https://issues.apache.org/jira/browse/FLUME-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628930#comment-15628930
 ] 

Theodore michael Malaska commented on FLUME-3020:
-------------------------------------------------

Hey [~bessbd]

So on your latest comment.  I'm not sure where you would want the 
StaticClass.init() function to be called from.

I tested the code and it looks like the static class will initiate when one of 
the followings lines are hit for the first time.

replacementString = InetAddressCache.hostName; 
replacementString = InetAddressCache.hostAddress;
replacementString = InetAddressCache.canonicalHostName;

The only place I would see to add the StaticClass.init would be at the init of 
the parent class, but that will take the small hit of the one time lookup even 
if the values are never used.

I'm personally in different.  Just let me know where you would like the 
StaticClass.init and let me know the value you are aiming to get from its 
placement.

Thanks

> Improve HDFSEventSink Escape Ingestion by more then 10x by not getting 
> InetAddress on every record
> --------------------------------------------------------------------------------------------------
>
>                 Key: FLUME-3020
>                 URL: https://issues.apache.org/jira/browse/FLUME-3020
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Theodore michael Malaska
>            Assignee: Theodore michael Malaska
>         Attachments: flume-3020.patch, flume-3020.patch.2
>
>
> If you are use escaping the current code will call InetAddress on every 
> record.  Which will result is a huge impact to performance.
> TotalTime,8403,
> totalEventTakeTime,1498,
> totalWriteTime,1981,
> totalWriterSetupTime,65,
> commitTime,201,
> flushTime,18,
> startTrans,7,
> The rest is all InetAddress



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to