----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53339/#review154723 -----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java (line 547) <https://reviews.apache.org/r/53339/#comment224391> nit: can you make this final - Jeff Holoman On Nov. 1, 2016, 8:16 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53339/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 8:16 p.m.) > > > Review request for Flume and Jeff Holoman. > > > Bugs: FLUME-3020 > https://issues.apache.org/jira/browse/FLUME-3020 > > > Repository: flume-git > > > Description > ------- > > If you are use escaping the current code will call InetAddress on every > record. Which will result is a huge impact to performance. > TotalTime,8403, > totalEventTakeTime,1498, > totalWriteTime,1981, > totalWriterSetupTime,65, > commitTime,201, > flushTime,18, > startTrans,7, > The rest is all InetAddress > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > cf0fbb0 > > Diff: https://reviews.apache.org/r/53339/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
