[ https://issues.apache.org/jira/browse/FLUME-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663241#comment-15663241 ]
Denes Arvay commented on FLUME-2988: ------------------------------------ Hi [~udai], thanks for the patch. The fix looks good for me, one comment: the {{Long.valueOf}} is not needed here, simply passing the {{kafkaFutures.size()}} to the method is enough. > Kafka Sink metrics missing eventDrainAttemptCount > ------------------------------------------------- > > Key: FLUME-2988 > URL: https://issues.apache.org/jira/browse/FLUME-2988 > Project: Flume > Issue Type: Bug > Components: Sinks+Sources > Reporter: Denes Arvay > Assignee: Udai Kiran Potluri > Priority: Minor > Attachments: FLUME-2988.1.patch > > > {{eventDrainAttemptCount}} doesn't get incremented in Kafka Sink, only the > {{eventDrainSuccessCount}} > (https://github.com/apache/flume/blob/trunk/flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java#L210) > resulting in misleading statistics (e.g. when calculating {{attemptCount - > successCount}}) -- This message was sent by Atlassian JIRA (v6.3.4#6332)