Hi All, I see that reviews are progressing well.
In my opinion, HTTP sink should be ready soon for inclusion / merge: the code seems tidy; I've ran a static analyser and it looks fine; I skimmed through the code multiple times and I find no obvious flaws. Also, it has been in use for HMRC for some times, I guess. Again, I'd like to kindly request everyone who has a few spare minutes to review and leave comments. (If you find no problems, then a LGTM, please.) Thank you, Donat 2016-11-10 1:25 GMT+01:00 Bessenyei Balázs Donát <bes...@apache.org>: > Hi All, > > Ben Wheeler has opened a Pull Request to help Flume have an integrated > HTTP Sink. > > Now, I'd like to ask everyone who has the time to help out with > reviewing the changes as they have a potentially high impact. > > Please, visit https://github.com/apache/flume/pull/84 and let us know > your comments and thoughts. > > > Thank you, > > Donat > > > 2016-10-20 23:19 GMT+02:00 Shang Wu (CS) <shang...@symantec.com>: > > Hi Donat and Ben, > > > > Thanks a lot for the consideration and I would love to provide helps if > needed, either something small like submitting a pom.xml or something large > like shaping the code to PR-ready stage. > > > > Thanks again. > > > > BR, > > Shang Wu, Senior Architect, BlueCoat, a Symantec Company > > > > On 10/20/16, 6:45 AM, "Balazs Donat Bessenyei" <bes...@cloudera.com> > wrote: > > > > I have contacted Ben Wheeler, the main author of > > https://github.com/hmrc/flume-http-sink . > > > > He said that they are open to contributing the feature to Apache > Flume. > > > > I will do my best to assist with the migration. > > > > > > Thank you, > > > > Donat > > > > > > On Tue, Oct 18, 2016 at 5:59 PM, Shang Wu (CS) < > shang...@symantec.com> wrote: > > > Hi Donat, > > > > > > Thanks a lot for the consideration. > > > > > > BR, > > > Shang Wu, Senior Architect, BlueCoat, a Symantec Company > > > > > > On 10/18/16, 1:56 AM, "Balazs Donat Bessenyei" < > bes...@cloudera.com> wrote: > > > > > > Hi Shang Wu, > > > > > > Thank you for your e-mail. > > > Both implementations seem to be good. (Also, their licences > fit the > > > Apache Flume codebase.) > > > https://github.com/hmrc/flume-http-sink is more recent. > > > > > > I'll ping hmrc soon to see if they are willing to create a pull > > > request. I think it would be a great improvement to Flume. > > > > > > If anyone has different ideas or objections, please let me > know. > > > > > > > > > Thank you, > > > > > > Donat > > > > > > On Mon, Oct 17, 2016 at 10:14 PM, Shang Wu (CS) < > shang...@symantec.com> wrote: > > > > Hi, > > > > > > > > > > > > > > > > We are Symantec Cloud Security group and Apache Flume looks > very promising > > > > for our backend components, especially its wide supports for > those popular > > > > data infrastructures via sources and sinks. > > > > > > > > Having said that, we are looking for a very generic approach > for restful > > > > API-based data storage systems, such as http sink, now. > > > > > > > > > > > > > > > > We’ve found two http sink implementations in github, as > follows, and would > > > > like to know any plan to include either of it, into the next > release of > > > > Apache Flume? > > > > > > > > > > > > > > > > https://github.com/josealvarezmuguerza/flume-http-sink > > > > > > > > https://github.com/hmrc/flume-http-sink > > > > > > > > > > > > > > > > Thanks adv. > > > > > > > > BR, > > > > > > > > Shang Wu, Senior Architect, BlueCoat, a Symantec Company. > > > > > > > > > > >
