Hi Christopher, was the concern behind just uploading test results as 
artifacts, that we'd run out of GitHub artifact space? GitHub documents 
(https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions#about-billing-for-github-actions)
 the storage limits, and I see that those are quite low and we could easily 
overrun them on busy repos (given the default retention period).

I'll sweep through the PRs - just wanted to understand what motivated you to 
introduce the condition.

Thanks.

Arvind Shyamsundar

-----Original Message-----
From: Christopher <ctubb...@apache.org> 
Sent: Monday, October 12, 2020 8:25 PM
To: fluo-dev <dev@fluo.apache.org>
Subject: [EXTERNAL] CI update (I made a mistake)

I made a mistake in my previous PRs to update us to GitHub Actions. I 
accidentally configured the workflows to save the test logs when the Maven step 
succeeds... rather than when it fails. So, the following PRs fix that, and save 
off the logs when the Maven task fails:

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-yarn%2Fpull%2F24&amp;data=04%7C01%7Carvindsh%40microsoft.com%7C329c19d93a4c4ba1528808d86f27a687%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637381564237354579%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=ZQXk5QuT3aEIGMCriBSg%2BFwJJDUwF2S3aKEbPZ4j7dQ%3D&amp;reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-recipes%2Fpull%2F156&amp;data=04%7C01%7Carvindsh%40microsoft.com%7C329c19d93a4c4ba1528808d86f27a687%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637381564237364569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=ybu9kQfGhX%2FyDEjh6CioNx3kpN80AyCKZovHdDWHipw%3D&amp;reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-examples%2Fpull%2F16&amp;data=04%7C01%7Carvindsh%40microsoft.com%7C329c19d93a4c4ba1528808d86f27a687%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637381564237364569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=XVijE8LAKMlpJKJufC3RMOX9Xaj2TPeQFDC6pgMiDXw%3D&amp;reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-bytes%2Fpull%2F10&amp;data=04%7C01%7Carvindsh%40microsoft.com%7C329c19d93a4c4ba1528808d86f27a687%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637381564237364569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=XSZR7U3U%2FLt4RCE8ZnfL%2FNblW997PjT5u6bU74yE%2F0g%3D&amp;reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo%2Fpull%2F1106&amp;data=04%7C01%7Carvindsh%40microsoft.com%7C329c19d93a4c4ba1528808d86f27a687%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637381564237364569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=8rFyYbJuZuTxistxgvlEGyLPvPsbh%2F4cJRORvkpBb2I%3D&amp;reserved=0

My mistake :)
Christopher

Reply via email to