Oh, interesting. That seems wrong. The Maven convention is that the test directory is supposed to contain code for testing that particular module. If there's nothing to test, it shouldn't exist. A separate module with integration test code should exist in src/main, like in Accumulo's accumulo-test module. Breaking that Maven convention seems to be resulting in confusing behavior of the maven-source-plugin and maven-javadoc-plugin.
On Mon, Jun 5, 2017 at 6:13 PM Keith Turner <[email protected]> wrote: > That module only has a src/test dir. There is no src/main dir. Maybe > that is the cause. > > On Mon, Jun 5, 2017 at 5:55 PM, Christopher <[email protected]> wrote: > > Neither fluo-integration jar which is missing javadocs are included in > the > > lib directory either, so I'm guessing they're just for testing. I'd still > > expect a javadoc and source jar for them, though. > > > > On Mon, Jun 5, 2017 at 5:43 PM Christopher <[email protected]> wrote: > > > >> The good: > >> > >> GPG signatures, hashes, SHA1 in Jar metadata all look good. > >> Source tarball matches SHA1 (except for generated DEPENDENCIES file from > >> Apache parent POM) > >> Tests with ITs pass > >> DISCLAIMER and LICENSE files are present and good > >> > >> The bad: > >> > >> The NOTICE file has the wrong copyright date (says 2016; should be 2017, > >> or 2016-2017 to be consistent with the generated NOTICE files in each > jar's > >> META-INF). > >> > >> The confusing/questionable: > >> > >> There's a few missing source and javadoc jars. I'm not sure if that's > >> intended, or how it happened: > >> fluo-integration-1.1.0-incubating-tests.jar is missing both > corresponding > >> source and javadoc jar > >> fluo-integration-1.1.0-incubating.jar is missing a corresponding javadoc > >> jar > >> > >> Several ERROR logs in the console during the build; probably expected, > >> from tests, but it's confusing, and could possibly be tests which aren't > >> checking for valid return codes or something. Could also just be a bad > log > >> configuration for the ITs: > >> > >> 2017-06-05 17:28:22,502 [config.FluoConfiguration] ERROR: Client > >> properties should not be set in your configuration if MiniFluo is > >> configured to start its own accumulo (indicated by > fluo.mini.start.accumulo > >> being set to true) > >> 2017-06-05 17:29:48,251 [server.AbstractNonblockingServer$FrameBuffer] > >> ERROR: Unexpected throwable while invoking! > >> 2017-06-05 17:29:55,779 [server.AbstractNonblockingServer$FrameBuffer] > >> ERROR: Read a frame size of 1633837924, which is bigger than the maximum > >> allowable buffer size for ALL connections. > >> > >> > >> On Mon, Jun 5, 2017 at 4:21 PM Keith Turner <[email protected]> wrote: > >> > >>> +1 > >>> > >>> * sig and hashes all checked out > >>> * Was able to build and test Fluo Recipes, Stress test, and Webindex > >>> against staging repo > >>> * Was able to run web index against tar ball from staging repo > >>> * source tar matches commit > >>> > >>> > >>> On Fri, Jun 2, 2017 at 12:53 PM, Keith Turner <[email protected]> > wrote: > >>> > Fluo Developers, > >>> > > >>> > Please consider the following candidate for Fluo 1.1.0-incubating. > >>> > > >>> > Git Commit: > >>> > ad8ee492e2f435405f98d825781098c55186f4fb > >>> > Branch: > >>> > 1.1.0-incubating-rc1 > >>> > > >>> > If this vote passes, a gpg-signed tag will be created using: > >>> > git tag -f -m 'Apache Fluo 1.1.0-incubating' -s > >>> rel/fluo-1.1.0-incubating \ > >>> > ad8ee492e2f435405f98d825781098c55186f4fb > >>> > > >>> > Staging repo: > >>> https://repository.apache.org/content/repositories/orgapachefluo-1017 > >>> > Source (official release artifact): > >>> > > >>> > https://repository.apache.org/content/repositories/orgapachefluo-1017/org/apache/fluo/fluo/1.1.0-incubating/fluo-1.1.0-incubating-source-release.tar.gz > >>> > Binary: > >>> > https://repository.apache.org/content/repositories/orgapachefluo-1017/org/apache/fluo/fluo/1.1.0-incubating/fluo-1.1.0-incubating-bin.tar.gz > >>> > (Append ".sha1", ".md5", or ".asc" to download the signature/hash for > >>> > a given artifact.) > >>> > > >>> > All artifacts were built and staged with: > >>> > mvn release:prepare && mvn release:perform > >>> > > >>> > Signing keys are available at > >>> https://www.apache.org/dist/incubator/fluo/KEYS > >>> > (Expected fingerprint: CF72CA07C8BC86A1C862765F9AACFB56352ACF76) > >>> > > >>> > Release notes (in progress) can be found at: > >>> > https://fluo.apache.org/.../1.1.0-incubating > >>> > > >>> > Please vote one of: > >>> > [ ] +1 - I have verified and accept... > >>> > [ ] +0 - I have reservations, but not strong enough to vote > against... > >>> > [ ] -1 - Because..., I do not accept... > >>> > ... these artifacts as the 1.1.0-incubating release of Apache Fluo. > >>> > > >>> > This vote will end on Mon Jun 5 17:00:00 UTC 2017 > >>> > (Mon Jun 5 13:00:00 EDT 2017 / Mon Jun 5 10:00:00 PDT 2017) > >>> > > >>> > Thanks! > >>> > > >>> > P.S. Hint: download the whole staging repo with > >>> > wget -erobots=off -r -l inf -np -nH \ > >>> > > >>> https://repository.apache.org/content/repositories/orgapachefluo-1017/ > >>> > # note the trailing slash is needed > >>> > >> >
