Hi, Cheng. Thanks for driving this FIP. The design looks good to me overall. But still few comments below:
1. About "Users can also explicitly specify the values for the AUTO_INCREMENT column and insert them into the table." Why allow users to explicitly specify the values? It'll break the uniqueness and may bring unexpected behavior. It feels a bit counterintuitive. If allow this, we should better to make sure it won't break uniquenes. Just as a reference, it seems many database vendor also ensure uniqueness for auto increment column 2. In "Specify AUTO_INCREMENT column at table creation" part, it seems auto-increment.fields be multiple columns, but in "Limits" part, it said "Each table can have only one AUTO_INCREMENT column." It does make me confused. What's the truth? 3. About "Implementation", it said " AutoIncIDBuffer also launches an asynchronous task to prefetch IDs from ZooKeeper." I'm wondering how to prefetch IDs from ZooKeeper? Can you explain it more? Maybe some piece of code can help explain. Best regards, Yuxia ----- 原始邮件 ----- 发件人: "Wang Cheng" <[email protected]> 收件人: "dev" <[email protected]> 发送时间: 星期四, 2025年 9 月 18日 下午 10:49:11 主题: [SPAM][DISCUSS] FIP-16: auto-increment column Hi all, Auto-increment column is a bread-and-butter feature for improving data management efficiency. It is the bedrock of many features in analytical workloads—such as those in real-time unique visitor (UV) counting scenarios. To implement this capability, I'd like to propose FIP-16: auto-increment column [1]. Any feedback and suggestions on this proposal are welcome! [1]: https://cwiki.apache.org/confluence/display/FLUSS/FIP-16%3A+Auto-Increment+Column Regards, Cheng
