The following comment has been added to this issue:

     Author: Ross Gardler
    Created: Wed, 23 Feb 2005 3:32 PM
       Body:
The style element in head is there for a reason. It is a hack to allow OOo 
documents to be created without using the template. However, it is true that 
this makes the document invalid - but it still works.

It has always been my intention to remove this hack and create a better way of 
doing it (in fact it sneaked into SVN by accident, I never realised until this 
patch was submitted). Recently a similar hack has emerged in the excel plugin. 
This has prompted me to write an RT that will address this (and other) issues - 
see http://marc.theaimsgroup.com/?l=forrest-dev&m=110918016421287&w=2.

In the short term I am -1 for this part (and only this part) of the patch being 
applied. It would break backward compatability for anyone who has used this 
undocumented feature. But does not cause any harm because it puts uses CSS 
class attributes in the xdoc itself.

To be clear I am +1 for the other parts of this patch. Lets apply the other 
parts and open a new issue for the style part.
---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-433?page=comments#action_12082

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-433

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-433
    Summary: OpenOffice.org plugin produces invalid intermediate documents
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Forrest
 Components: 
             Plugin: OpenOffice.org
   Fix Fors:
             0.7
   Versions:
             HEAD

   Assignee: 
   Reporter: Florian G. Haas

    Created: Fri, 4 Feb 2005 4:06 PM
    Updated: Wed, 23 Feb 2005 3:32 PM
Environment: Tested on Debian Sarge with Linux 2.4.27 an JDK 1.4.2

Description:
The intermediate XML produced by the OOo plugin does not conform to the 
document-v12 DTD, even though the xsl:output element in 
openoffice-common2forrest.xsl says so. In particular:

* The intermediate document contains a <style> element inside <header>; invalid 
per the DTD.
* <p> elements contain a "class" attribute; invalid per the DTD.
* <fixme> elements do not contain an "author" attribute, though required by the 
DTD.

Steps to reproduce:
* Run "forrest run" from the plugins/org.apache.forrest.plugin.OpenOffice.org 
subdirectory of your Forrest checkout.
* Download http://localhost:8888/samples/openoffice-writer.xml and have the 
document checked by your favorite validating parser.

The trouble with this is that the FO stylesheets carry the contents of the 
<style> element over into the result tree, where they pop up as part of the 
ToC. This looks like fairly meaningless gibberish to the reader of the 
resulting PDF (etc.) document. You may verify this by checking 
http://localhost:8888/samples/openoffice-writer.pdf in the above-mentioned 
setup. 


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

Reply via email to