Ron Blaschke wrote:
Friday, June 17, 2005, 11:54:47 AM, Ross Gardler wrote:

Ron Blaschke wrote:

Unable to retrieve the ${plugin.name} plugin.

Two noteworthy things: Calling "forrest init-plugins" installs the
plugin sucessfully.  And the error message says "${plugin.name}",
instead of the real name of the plugin.


The two things are related. It looks like that the {plugin.name} is not
being set for some reason (and I guess {versioned.name} is not set either.


These are set in the init-plugins target of targets/plugins.xml


I ran my build.xml with "ant -d," and found the following:

  Setting ro project property: plugin.name -> ${plugin.name}
  Setting ro project property: plugin.version -> ${plugin.version}
  Setting ro project property: versioned.name ->
org.apache.forrest.plugin.input.projectInfo

Actually that is as expected. The {plugin.name} and {plugin.version} values are set by a regexp looking for the the version number. Since there is no version number in the plugin required the regexp fails and so no value for the property. The rest of the script tries to get the {versioned.name} plugin. If it fails it falls back to the unversioned plugin.

This explains why the error message shows ${plugin.name}, I've changed that to use the {versioned.name} so at least it will give a more meaningful error.

"forrest -d" says:

  Setting ro project property: plugin.name ->
org.apache.forrest.plugin.input.projectInfo
  Setting ro project property: plugin.version ->
  Setting ro project property: versioned.name ->
org.apache.forrest.plugin.input.projectInfo

This I don't understand. The bechaviour should be the same as above. The relevant portion of the ANT script is at line 337 of targets/plugins.xml


My forrest.properties says this:

  project.required.plugins=org.apache.forrest.plugin.input.projectInfo,
org.apache.forrest.plugin.input.simplifiedDocbook

I assume you get the same behaviour with simplifiedDocbook?

Out of curiosity, I added the plugin version.

  project.required.plugins=org.apache.forrest.plugin.input.projectInfo-0.1,
org.apache.forrest.plugin.input.simplifiedDocbook

The debug trace of my build.xml changes to the following, and the
plugin is successfully installed.

  Setting ro project property: plugin.name ->
org.apache.forrest.plugin.input.projectInfo
  Setting ro project property: plugin.version -> 0.1
  Setting ro project property: versioned.name ->
org.apache.forrest.plugin.input.projectInfo-0.1

This looks like the behaviour expected.

I have no idea why this is happening and don't have the time to explore
this just yet. I can't raise an issue either since the issue tracker is
down right now.


I hope it's alright for everyone that I am thinking out loud here.  If
not, please tell me so.

We certainly don;t mind you helping debug the problem. Every step you take like the above is one less step other devs have to take in debugging. We are *very* grateful for your thoughts.

Furthermore, our conversation here goes in the archives and helps people debuging similar stuff in the future.

If you think that I really found a bug, and not just made a stupid
mistake, I'll gladly create an issue myself, and try to help resolving
it.

You certainly found what looks like a bug. Please do raise an issue and link it to this thread in the archives, you have provided some useful info here.

We are only an hour from the second release build so I'll add a warning and a workaround in the docs for this.

Ross

Reply via email to