----- Original Message -----
From: "Ross Gardler" <[EMAIL PROTECTED]>
To: <dev@forrest.apache.org>
Sent: Tuesday, December 13, 2005 7:32 AM
Subject: Re: Forrest Proxy Settings
| Gav.... wrote:
| > The current init-proxy target says:-
| >
| > <target name="init-proxy" if="proxy.host">
| > <property name="proxy.port" value="80"/>
| > <echo>Using proxy : ${proxy.host}:${proxy.port}</echo>
| > <setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
| > </target>
| >
| > Would changing it to this be enough or is there more to do :-
| >
| > <target name="init-proxy" if="proxy.host">
| > <property name="proxy.port" value="80"/>
| > <property name="proxy.user" value=""/>
| > <property name="proxy.password" value=""/>
| > <echo>Using proxy : ${proxy.host}:${proxy.port}</echo>
| > <echo>Using Username : ${proxy.user}:${proxy.password}</echo>
| > <setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
| > <setproxy proxyuser="${proxy.user}"
proxypassword="${proxy.password}"/>
| > </target>
| >
| > After which , proxy.user and proxy.password can then be set in project
| > properties.
|
| I don't know if it works or not because I'm not behind an authenticating
| proxy so can't easily test. I do have a few observations though:
I can't test either as I dont have proxy at all, just trying some ideas.
|
| I don't think there would be two setproxy tasks and it is best not to
| echo the password to screen (people looking over shoulders, logging
| scripts etc.)
Ok, so combine the setproxy tasks together and dont echo the password,
I'll change it.
|
| Also I'm not sure of the default behaviour if no user/password
| combination is provided. Would need to check the Ant manual for that, it
| may be necessary to put a guard on there if they are not set.
Ant Manual says that proxyuser has a default of "" and proxypassword is
only checked/used if proxyuser has been set (other than default) so I
assumed I was ok with what I did.
|
| The defaults should really be set in defaults.forrest.properties - not
| in the forrest.build.xml (this goes for proxy.port as well).
The proxy.poer setting was already there. The target is 'init-proxy' I
assumed
meaning 'initial proxy settings' and therefore default, to be overridden in
project.properties. I'll take a look in defaults.forrest.properties.
I'll post a revised version later.
Thanks
Gav...
|
| Ross
|
|
| --
| No virus found in this incoming message.
| Checked by AVG Free Edition.
| Version: 7.1.371 / Virus Database: 267.13.13/197 - Release Date: 9/12/2005
|
|
--
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.1.371 / Virus Database: 267.13.13/197 - Release Date: 9/12/2005
