----- Original Message ----- From: "Cyriaque Dupoirieux" <[EMAIL PROTECTED]> To: <[email protected]> Sent: Tuesday, February 14, 2006 4:32 PM Subject: Re: [jira] Updated: (FOR-811) shine and polish the pelt theme so that it closely resembles the pelt skin
| Gavin (JIRA) a écrit : | > [ http://issues.apache.org/jira/browse/FOR-811?page=all ] | > | > Gavin updated FOR-811: | > ---------------------- | > | > Attachment: pelt.fv.diff | > pelt.screen.css.diff | > siteinfo-credits.ft.diff | > | > 3 Attatchments go a way towards addressing this issue. There are still some minor adjustments to make, however what has been done needs checking first. The CSS file pelt.basic.css has been done away with and any applicable CSS from it transferred into pelt.screen.css. Some changes were required also to pelt.fv and siteinfo-credits.fv. | > | Thank you for you work Gavin, | | Don't understand why the basic has been removed ? | It must contain the css applicable independently of the device (print, | screen...) Doesn't it ? Not as far as I know it doesn't. Default device is screen anyway, the print.css is still there, to strip away anything that does not need printing - that needs looking at too anyway. The leather-dev.css is still there, and anything else can be used if need be using inheritence to override any css in screen.css such as if a pda/mobile view was needed. There was duplicate and conflicting code on basic and screen that I didnt see as being inheritence. As part of the pelt theme conversion and cleanup it was discussed last Forrest Friday and consensus was that we merge some css together. If you find a compelling reason to keep basic.css let us know, it is gone from my system only atm. I could not see how basic.css could be used on its own. Gav... | | Cyriaque, | | > Please check & Test, I have tested these files using a dispatcher enabled seed-sample site using forrest run. | > | > | >> shine and polish the pelt theme so that it closely resembles the pelt skin | >> -------------------------------------------------------------------------- | >> | >> Key: FOR-811 | >> URL: http://issues.apache.org/jira/browse/FOR-811 | >> Project: Forrest | >> Type: Sub-task | >> Components: Skins (general issues), Dispatcher (aka views) | >> Reporter: David Crossley | >> Attachments: pelt.fv.diff, pelt.screen.css.diff, siteinfo-credits.ft.diff | >> | >> So that they can just switch from "pelt skin" to "pelt theme" and not get any surprises, e.g. "pelt skin' has no "xml doc" link. | >> | > | > | | | -- | No virus found in this incoming message. | Checked by AVG Free Edition. | Version: 7.1.375 / Virus Database: 267.15.7/259 - Release Date: 13/02/2006 | | -- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.1.375 / Virus Database: 267.15.7/259 - Release Date: 13/02/2006
