> David Crossley commented on FOR-639: > ------------------------------------ > > Thanks, patches applied. I will follow up separately regarding a few comments > that will help with your patches. > > BTW, please keep the issues separate, e.g. this FOR-639 should be about the > site-author/contents/xdocs/glossary.xml file and we should have separate > issues for each particular enhancement to the Glossary Plugin itself.
Hi Gavin, a few notes i made when applying this patch. Just intended to be hints to ease the way for us all ... ------- You missed some files with this most recent patch, i.e. forgot to send the changes to site-author/.../glossary.xml and for the plugin's example glossary.xml to add your <definitions> elements. I added those myself, otherwise it broke the builds. To help with that, do cd $FORREST_HOME svn status ... that shows what files you changed. If you only have these changes, then do:svn diff > my-patch,txt Otherwise if there is other stuff that you don't want to add, then do: svn diff site-author whiteboard/plugins/org.apache.forrest.plugin.input.glossary > my-patch.txt ------- Your patch had full local filesystem path, i.e. D:/Apache2/forrest/whiteboard/... Better to start from $FORREST_HOME. The committer can easily cope with it, but extra work. ------- You removed the <p> wrapper on each "definition" so now subsequent definitions are jumbled together. -David
