[ 
https://issues.apache.org/jira/browse/FOR-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619812#action_12619812
 ] 

Johannes Schaefer commented on FOR-211:
---------------------------------------

I've had a quick look at the wholesite.html from 'forrest seed':
1. Most (internal) links seem to work properly
2. External links [1] with "ext:" don't work.
  This may be fixed by adding another "or" clause to doc-to-doc-uniqueids.xsl

  <xsl:template match="section/document//link/@href[not(starts-with(., 'http:') 
or starts-with(., 'https:')
      or starts-with(., 'site:') or starts-with(., 'ext:'))]">

This is great progress!

3. There are still some links that won't work (properly), e.g. 
  http://localhost:8888/wholesite.html#sample.xml
  http://localhost:8888/wholesite.html#../index.html
  http://localhost:8888/wholesite.html#pluginDocs/plugins_0_90/
  http://localhost:8888/wholesite.html##section
  http://localhost:8888/wholesite.html#../samples-c/subdir/index.html
  http://localhost:8888/wholesite.html#../samples-c/subdir/hello.zip
  http://localhost:8888/wholesite.html#../old_site/test1.html
  http://localhost:8888/wholesite.html#samples-b/
  ALTHOUGH http://localhost:8888/wholesite.html#samples-b/faq.html WORKS!
  http://localhost:8888/wholesite.html#ellipse.png
  http://localhost:8888/wholesite.html#introduction

You could check a freshly seeded site and see if you get some insights and
improve on your patch.

I did not check the tabs-pdf, though (I never needed it so far)

[1] http://forrest.apache.org/docs_0_90/linking.html#resolve-ext-uris


> whole-site html and pdf: broken ext links
> -----------------------------------------
>
>                 Key: FOR-211
>                 URL: https://issues.apache.org/jira/browse/FOR-211
>             Project: Forrest
>          Issue Type: Bug
>          Components: Core operations
>    Affects Versions: 0.6
>            Reporter: David Crossley
>             Fix For: 0.9-dev
>
>         Attachments: wholesite_pdftab_patch.txt
>
>
> In the the generated site.html all of the external links are broken (i.e. the 
> href attributes are like ... error:#ext:forrest).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.