On Thu, 2008-08-21 at 16:19 +1000, David Crossley wrote:
...
> I found the problem. It was the Cocoon configuration file.
> 
> In my working setup, i had kept our old configuration
> by copying the content of our main/webapp/WEB-INF/xconf/forrest-core.xconf
> into main/webapp/WEB-INF/cocoon.xconf (see FOR-955).
> 
> In your setup, i am not clear where you got the content from.
> Perhaps it was direct from the Cocoon-2.1 cocoon.xconf file
> or from its build/webapp/WEB-INF/cocoon.xconf which is produced
> after processing block configurations.

Hmm, I thought that I did exactly this (copying the content from our
forrest-core.xconf). 

> 
> So it has some different parameters to ours, e.g.
> the "catalog" parameter for "entity-resolver".
> Hence the error described above.

Thanks very much to find the cause of the problem and fix it. 


> It also uses the "Cocoon properties" system to set some values, e.g.
> <parameter name="freememory" value="${store-janitor.freememory}"/>
> In the Cocoon-2.1 SVN those values come from
> src/webapp/WEB-INF/properties/core.properties
> A while ago i added that ability to Forrest (FOR-917)
> so we should now be able to set up something similar.
> 

I do not understand I can find
main/webapp/WEB-INF/properties/core.properties but there is no
store-janitor.freememory property in this file. 

If I understand correctly we should move this property (and I guess
other as well)  to this properties file, right?

> I will work on this aspect of our upgrade.
> It is a big task. We need to find some way to make
> it easy to keep the configuration synchronised with
> that at Cocoon-2.1 and its blocks config, each time
> we upgrade our packaged Cocoon.

In lenya there is a cocoon as svn:external that are used every time you
build.  There we are patching the default cocoon files like

<!-- Patch cocoon.xconf -->
    <property name="patch.webapp" value="true"/>
    <xpatch file="${build.webapp}/WEB-INF/cocoon.xconf"
      srcdir="${build.patch}/cocoon-xconf" 
      includes="prepare/*.xconf"
      addComments="true"/>
    <xpatch file="${build.webapp}/WEB-INF/cocoon.xconf"
      srcdir="${build.patch}/cocoon-xconf" 
      includes="**/*.xconf"
      excludes="prepare/*.xconf"
      addComments="false"/>

Something similar may work for us when we update. The best would be to
use ant to do the update process for us.

I will try to bring back forrest site since that is failing:
* [1/0]     [0/0]     1.203s 0b      linkmap.html
org.apache.cocoon.sitemap.PatternException: Cannot get variable
'plugin.xmap.output' in expression '{lm:plugin.xmap.output}'
        at
org.apache.cocoon.components.treeprocessor.variables.PreparedVariableResolver.processModule(PreparedVariableResolver.java:262)
        at
org.apache.cocoon.components.treeprocessor.variables.PreparedVariableResolver.resolve(PreparedVariableResolver.java:209)

in forrest run that is no problem.

salu2
> 
> -David
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions