On Mon, 2010-02-22 at 11:48 +0100, Thorsten Scherler wrote:
> On Mon, 2010-02-22 at 20:22 +1000, Gav... wrote:
> > 
> > > -----Original Message-----
> > > From: David Crossley [mailto:cross...@apache.org]
> > > Sent: Monday, 22 February 2010 8:11 PM
> > > To: dev@forrest.apache.org
> > > Subject: Re: Can't get Dispatcher working at all windows/linux from
> > > trunk
> > > 
> > > Gav... wrote:
> > > >
> > > > I see Davids thread 'strange dispatcher behaviour after merge' is
> > > exactly the same problems
> > > > as I am getting now. David, I see no follow up solution, what did you
> > > do to get it going again?
> > > >
> > > > I also note Brian says he is not having any issues either, Brian,
> > > what did you need to change
> > > > to get dispatcher in current trunk working for you?
> > > 
> > > I did *not* get it working. I needed to go back to before
> > > the Dispatcher merge. I did 'svn up' to r882421 2009-11-20.
> > 
> > Ah right, ok, same as what I did then, 'somebody' must have it working 
> > and it needs to be sorted soon otherwise it doesn't belong in trunk.
> 
> Hmm, I will try now as well. Can you post the exception that you got
> again, please?

Its pasted into the bottom of the original message in this thread
earlier today. However there may be no need, see below....

> 
> 
> 
> > 
> > > 
> > > As said before, one of the issues is the agreed Java base version.
> > > See the "build.compiler.vm" parameter in our build.xml
> > > and instructions in the Release documentation and recent discussion
> > > in these dev archives.
> > 
> > Yep, I read briefly but need to go back in case I missed something.

And there lies the clue!

Despite having set default java to either 1.5 or 1.6, despite setting
JAVA_HOME to point to 1.5 or 1.6, it still compiled using 1.4 due to the
fact that the build.compiler.vm was still set at 1.4 !!

I have now brought my local copy back up to trunk:HEAD, changed the
setting to 1.5, changed the JAVA_HOME to 1.5 and Dispatcher now works
fine on Windows and Linux !!

(Have others tried that and had success/failure)

Looking at the Forrest Zone at

http://forrest.zones.apache.org/ft/build/forrest-sample-2/

it is clearly not using Dispatcher.

I also tested in 1.6 and get the following compile errors:

compile:
Created dir: /home/gmcdonald/asf/forrest/build/classes
Compiling 33 source files to /home/gmcdonald/asf/forrest/build/classes
/home/gmcdonald/asf/forrest/main/java/org/apache/forrest/util/IdGeneratorTransformer.java:177:
 unmappable character for encoding UTF8
                //      - <a href="#Quelques+r%E8gles...">Quelques
r�gles...</a
                                                                    ^
/home/gmcdonald/asf/forrest/main/java/org/apache/forrest/util/IdGeneratorTransformer.java:180:
 unmappable character for encoding UTF8
                //      - <a href="#Quelques+r%C3%A8gles...">Quelques
r�gles...</a>
                                                                       ^
2 errors

So, getting closer to having 1.6 work too.

> > 
> > One thing is for sure, the forward momentum of this project depends on this
> > being resolved, and soon. We should vote on a minimum version of java soon, 
> > then work on fixing it for that version - as tried and tested as much as I 
> > have, dispatcher for me doesn't work in any of them.
> 
> I personally prefer to use 1.6 as minimum since 1.4 and 1.5 are not
> officially supported anymore. However to make the dispatcher work with
> 1.4 is not that hard since it is mostly generic compilation exception. 

If others can test, and it is as simple as upping the build.compiler.vm
setting, then I say we should do it right now, but others may have other
views.

As we are still in the 0.X range of release versions, then if we can fix
the above UTF8 problem I'd be happy to go straight to 1.6


Thanks for looking into it.

Gav...

> 
> salu2