Hello Fridrich!
You cws "libwpdupgrade" was integrated into an SRC680 m83 milestone. So the regression was made between m82 and m83. Your patch was applied to a new cws "fwkfinal1" based on a m83 version. It will be integrated asap.
As a result of these fixes the following behaviour should exist:
a) well known and supported word perfect files should be opened using your word perfect filter
b) any other format should be opened by any other suitable filter (of course)
c) and unknwon format (e.g. pdf files which are supported for export but not for import) must bring up the filter selection dialog, where the user can force opening this unknwon file using a special filter. Of course there is no guarantee, that it will not have any side effects .-)
Because any filter must deal with the situation, that a complete unknown format is provided to the filter.
Note:
A deep detection service has to return an empty string for unknown formats and a well defined string for supported formats.
A filter has to return TRUE/FALSE only as a result of it's operation.
Throwing of exceptions is limited to RuntimeExceptions only. Errors has to be handled gracefully using the interaction concept. It's not allowed to show dialogs directly!
You can verify your changes on the cws "fwkfinal1" now ... or you can wait for it's integration into the master.
You problem regarding the shown error box
"Read-Error. Cannot read the file"
seems to be a problem of another deep detection module.
May be it does not use the provided input stream and try to open the file again ... which is normaly locked then and can't be opened read/write normaly then.
On the other side the file is opened by the generic typedetection framework at a central place so problems regarding opening the file are handled one times only. We had several bugs before ... because every modules used by the typedetection framework tried to open the stream ...
But in case the url was wrong it was tried more then ones ... and of course the corresponding error message was shown more then once too.
BTW: I can't reproduce this error message on a normal m83 version nor on the cws fwkfinal. But you can send me the debugger output ... if it contains more then library names only .-)
email: [EMAIL PROTECTED] or [EMAIL PROTECTED]
Regards Andreas
Hello,
I would need your help for the following problem:
In milestome m83, we introduced (and we are deeply sorry for it) a regression with our WordPerfect import filter. Due to some flaws in our handling of OLE2 documents, the WordPerfect TypeDetection was throwing an NotConnectedException (http://www.openoffice.org/issues/show_bug.cgi?id=43995).
We produced a patch that fixes this issue. It was reported as solving a problem by a person who was building m79 with CWS libwpdupgrade merged in. I has a funny behaviour on m82 with the same CWS merged. The WP TypeDetection did not throw any exception and actually returned empty string since the document (a MS Word document without extension) was detected as not being WordPerfect document. Immediatelly after this, we receive an pop-up window saying "Read-Error. Cannot read the file".
During week-end I rebuilt the m83 milestone (with my patch) with debug and tried today whether the problem was just my hoaked build system or not. I run the soffice.bin in gdb and have the output.
My questions are:
1) Is there something substantial that changed between m79 and m83 concerning the typedetection that could be reason of the difference of behaviour between the two builds?
2) Would someone be interested in examining the output of soffice.bin running in gdb? It is 19kB.
Thanks in advance for your help
Fridrich
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
