Hello Yan Wu,
Hello Andreas,
a)I have separated the ConfigItemTest.cxx, now each config item will
have a single test code like AccessibilityOptTest.cxx,HistoryOptTest.cxx.
Looks fine. I've already checked in these files.
Small hint: The new helper class LogHelper shouldnt be used here.
First it's header isnt accessible from the qa/complex directory ..
further exceptions shouldnt be catched during tests. Every exception can
show an error and we have to improve the code and the test till no
further error occure. So please dont catch exceptions inside tests -
throw some more .-)
b)In the HistoryOptTest.cxx, when clearing the list in XML directly I
referenced the comphelper/../configurationhelper.cxx.
Good - it's the right way doing this.
c)Perhaps I have to test more deep.
Of course we have to check more. At least it would be great if every
public C++ method of a changed config item will be verified.
Example:
pHistory->SetSize(..) <-> xCfg->getpropertyValue(...)
xCfg->setPropertyValue(...) <-> pHistory->GetSize()
pAccessibility->SetAutoDetectSystemHC(..) <-> xCfg->getpropertyValue(...)
xCfg->setPropertyValue(...) <-> pAccessibility->SetAutoDetectSystemHC(..)
etcpp.
Feel free to give your fancy full scope by writing these tests .-)
I know - doing so can be more epxensive then rewriting the config item
classes itself. But it's an investment into the future.
Need your help for reviewing the attached files.
Regards,
Yan Wu
Best Regards
Andreas
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
