Mathias Bauer wrote:
Andreas Schlüns wrote:
Hello Yan Wu,
Hi Andreas,
When redesigning svtools\source\config\useroptions.cxx,
I made like below changes:
String SvtUserOptions_Impl::GetFirstName() const
{
::rtl::OUString sFirstName;
try
{
m_xData->getPropertyValue(s_sgivenname) >>= sFirstName;
}
catch ( const css::uno::Exception& ex)
{
LogHelper::logIt(ex);
}
return String(sFirstName);
}
The OOo still will crash when opening Menu:Tools->Options. The crash
point is aFirstName.SetText( aUserOpt.GetFirstName() ) in
SvxGeneralTabPage::SetAddress_Impl();
BTW, "const String& SvtUserOptions::GetFirstName() const" isnt made any
changes. Does this method need changes too?
Yes - of course this method needs to be redesigned too.
While we are at it (and need to recompile anyway): would it make sense
to get rid of the tools String here? Why converting the available
rtl::OUString to a tools String, let the client decide whether this is
needed at all.
Yes,we shouldnt use the tools String in any new code. Now the
rtl::OUString has been remained.:-)
Ciao,
Mathias
Regards
Yan Wu
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
