Friday, September 7, 2018, 5:57:43 PM, Daniel Dekany wrote:
> Friday, September 7, 2018, 4:54:15 PM, Ben Jackson wrote:
>
>> I like the name FreeMarker Generator (Maven Plugin). I think we should
>> name the repo freemarker-generator, and then leave open the possibility of
>> providing additional ways to drive the code generation through additional
>> build tools.
>
> Indeed, good point. That will be a multi module Maven project, with
> freemarker-generator-core and freemarker-generator-maven-plugin
> submodules.
>
>> - Yes, I believe we can follow a simple CLA process. I will open a
>> ticket today for us to sign the CLAs.
>
> So, both of you should sign an ICLA ("I" for Individual). It's easy;
> print it, sign it, scan it, e-mail it. Then you can contribute to any
> Apache projects on your free time, so it never hurts to have one.
>
> Then, certainly we will also need a CCLA ("C" for Corporate) for the
> contribution, assuming you did this as part of your work, or if your
> employer can claim that for any other reason. The signer of the CCLA
> has to be someone who has right to make such a legal statement in the
> name of the company. But maybe wait until some more FreeMarker PMC
> members respond to this.
So, the decision on our side is that we go on as planned earlier. If
you agree, you should submit the CCLA (in additionally to the ICLA-s).
In the CCLA, under "Initial list of designated employees", please add
the names of both of you. Again, the signer (and presumably who fills
the whole CCLA) is not you, but someone at Oath Inc. who has right to
make such a legal statement.
Assuming you intend to develop the freemarker-generator further, you
can also gain Committer status, which practically means that you can
work directly (without PR) on the Git repo, or merge PR-s.
> See: https://www.apache.org/dev/new-committers-guide.html#cla
>
>> - Only Mark and I have contributed to this codebase.
>> - Only Mark and I currently have contributor rights to the codebase I
>> shared.
>
> In work time, right?
>
>> - Names.
>>
>>
>> - The repository "freemarker-generator"
>> - The readme "FreeMarker Generator" or "FreeMarker Generator Maven
>> Plugin" (for now, as this is what it limited to)
>> - We would use the Maven *groupId:* "org.apache.freemarker"
>> - We would use the package prefix: "org.apache.freemarker.generator"
>> - We would use the artifact/plugin name:
>> "freemarker-generator-maven-plugin"
>> - The default locations would be
>> - src/freemarker-generator
>> - src/freemarker-generator/template
>> - src/freemarker-generator/generator
>> - target/generated-sources/freemarker
>
> I agree, assuming the last meant to be
> target/generated-sources/freemarker-generator.
>
>>
>> - What specifically to replace the copyright with? I am sure the open
>> source team can also help me here if there is no specific answer on your
>> end.
>
> Same header as you see in almost all Apache project files:
>
> /*
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> * distributed with this work for additional information
> * regarding copyright ownership. The ASF licenses this file
> * to you under the Apache License, Version 2.0 (the
> * "License"); you may not use this file except in compliance
> * with the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing,
> * software distributed under the License is distributed on an
> * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> * KIND, either express or implied. See the License for the
> * specific language governing permissions and limitations
> * under the License.
> */
>
> package org.apache.freemarker.generator;
> ...
>
>> -Ben
>>
>>
>>
>>
>>
>> On Fri, Sep 7, 2018 at 9:23 AM Woonsan Ko <[email protected]> wrote:
>>
>>> On Fri, Sep 7, 2018 at 3:29 AM Daniel Dekany <[email protected]> wrote:
>>> >
>>> > Thursday, September 6, 2018, 6:27:34 PM, Ben Jackson wrote:
>>> >
>>> > > BTW,
>>> > >
>>> > > The naming convention for maven plugins is either 'maven-XXX-plugin' if
>>> > > supported by the maven team or 'XXX-maven-plugin' for all other
>>> plugins;
>>> > > this why Mark originally named it freemarker-maven-plugin. See
>>> > >
>>> https://maven.apache.org/guides/plugin/guide-java-plugin-development.html
>>> > >
>>> > > So someone looking for this plugin will almost certainly default to
>>> > > searching for "freemarker-maven-plugin" so it is possible that the
>>> existing
>>> > > name is the superior choice.
>>> >
>>> > I think they will just search the web for `freemarker maven plugin`,
>>> > and not `freemarker-maven-plugin`. So if the thing is called, for
>>> > example, "FreeMarker Generator Maven Plugin", it will be still a top
>>> > hit (especially if someone also looks for "generating" source code
>>> > with FreeMarker). And then the directory can be
>>> > "freemarker-generator", not the overly generic "freemarker" (which can
>>> > lead to some confusion, like people put their e-mail templates there,
>>> > instead of /src/resources/freemarker/).
>>> >
>>> > But it's not like I want to drag this too long. Either one is
>>> > acceptable to me. So, guys, care for a totally informal vote? (We can
>>> > do a formal one in case no consensus reached soon.)
>>> >
>>> > I prefer ("Offical name" (artifact-name; src/directory-name):
>>> >
>>> > A "Apache FreeMarker Maven Plugin"
>>> > (freemarker-maven-plugin; src/freemarker)
>>> >
>>> > B "Apache FreeMarker Generator Maven Plugin"
>>> > (freemarker-generator-maven-plugin; src/freemarker-generator)
>>> >
>>> > C "Apache FreeMarker File Generator Maven Plugin"
>>> > (freemarker-file-generator-maven-plugin;
>>> src/freemarker-file-generator)
>>> >
>>> > D Something else (please provide the name)
>>> >
>>> >
>>> > I vote for B.
>>> Me, too. :-)
>>>
>>> Woonsan
>>>
>>> >
>>> >
>>> > > -Ben
>>> > >
>>> > >
>>> > > On Thu, Sep 6, 2018 at 11:14 AM Ben Jackson <[email protected]>
>>> wrote:
>>> > >
>>> > >> Here is the existing codebase for this project.
>>> > >>
>>> > >> https://github.com/yahoo/freemarker-maven-plugin
>>> > >>
>>> > >> It seemed more straightforward to work through our opensource team to
>>> > >> publish the code so that it could be reviewed before continuing this
>>> > >> conversation. Please comment on any remediations you see as needed
>>> (if
>>> > >> any) before working towards gifting this code to the apache
>>> foundation as a
>>> > >> starting point for this plugin.
>>> > >>
>>> > >> Also, as mentioned in the conversation above, it would be preferable
>>> if
>>> > >> this plugin had a unique and easily searchable name. Does anyone have
>>> > >> ideas?
>>> > >> I have no good ideas; here are some uninspired options:
>>> > >>
>>> > >> FreeGenerator
>>> > >> FMGenerator
>>> > >> FMGen
>>> > >> fmg
>>> > >> fmgen
>>> > >> FMarkerGen
>>> > >> MarkerGen
>>> > >> MGen
>>> > >> MGenerator
>>> > >>
>>> > >>
>>> > >> On Mon, Aug 20, 2018 at 10:05 AM Woonsan Ko <[email protected]>
>>> wrote:
>>> > >>
>>> > >>> On Mon, Aug 20, 2018 at 10:15 AM, Daniel Dekany <[email protected]>
>>> > >>> wrote:
>>> > >>> ...snip...
>>> > >>> > Without an ASF account the contributors couldn't edit the Wiki
>>> page.
>>> > >>> > If *they* open a JIRA issue, then we all can edit it. So that's
>>> what I
>>> > >>> > recommend.
>>> > >>> Makes sense to me. We can wait for Ben/Mark to create a JIRA ticket
>>> > >>> and we can edit its description together there.
>>> > >>>
>>> > >>> ...snip...
>>> > >>> > This was my intent from the beginning. A generator file can be a
>>> > >>> > .json, or an .ftl[h|x] (or whatever we come up with later, like an
>>> xml
>>> > >>> > that's transformed by a templates/myxmltransformat.ftl). They are
>>> > >>> > totally unrelated, independent generator files. I have never
>>> assumed
>>> > >>> > that they come in pairs, hence there was never a such thing as "ftl
>>> > >>> > only generator" in my head either. All generator files are lonely.
>>> > >>> That's clear now. I think I made an unnecessary confusion by using
>>> > >>> 'ftl-only' generator when mentioning .ftl type generator.
>>> > >>> Thanks!
>>> > >>>
>>> > >>> Woonsan
>>> > >>>
>>> > >>
>>> > >>
>>> > >> --
>>> > >> Benjamin Grant Jackson
>>> > >>
>>> > >
>>> > >
>>> >
>>> > --
>>> > Thanks,
>>> > Daniel Dekany
>>> >
>>>
>>
>>
>
--
Thanks,
Daniel Dekany
