+1 (binding) Jacopo
On Sun, Dec 8, 2024 at 4:36 PM Daniel Dekany <ddek...@apache.org> wrote: > Hi all, > > Please vote on releasing FreeMarker 2.3.34! > > This is "attempt 2", after the previous 2.3.24 release voting did not pass. > The only significant difference > compared to the previous attempt should be that now the bug fix for the > "sep" tag parsing is only enabled > if incompatibleImprovements >= 2.3.34. > > ATTENTION! Delete the previous org.freemarker:freemarker:2.3.34 artifact > from your local > Maven repository (~/.m2/repository/org/freemarker), or else Maven will keep > using it! > > Release Notes: > https://freemarker.apache.org/builds/2.3.34-voting/versions_2_3_34.html > > Before proceeding, you should know that FreeMarker 2.3.x, for a long > time, always releases a normal and a "gae" variant on the same time, > which are technically two independent source trees (Git branches). The > "gae" variant contains a few small modification in the Java source > code to be Google App Engine compliant, and has freemarker-gae as the > Maven artifact name. Otherwise the normal and the "gae" branches are > identical. Hence they will be voted on together. > > The commits to be voted upon are: > - Normal (non-gae) variant: > > > https://github.com/apache/freemarker/commit/7926e97719a91c69995e776dd1aae3d38584d8af > Commit hash: 7926e97719a91c69995e776dd1aae3d38584d8af > - "gae" variant: > > > https://github.com/apache/freemarker/commit/e263604781736d182191f4603fad94d1333b0034 > Commit hash: e263604781736d182191f4603fad94d1333b0034 > > The artifacts to be voted upon are located here: > > where the source release artifacts are: > > https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.34-attempt-2/source/ > - Normal (non-gae) variant: > apache-freemarker-src-2.3.34.tar.gz > - "gae" variant: > apache-freemarker-gae-src-2.3.34.tar.gz > > See the "Building FreeMarker" section of the README.md inside them for > build instructions! > As described there: > - You need to add the gradle-wrapper.jar manually > - You need multiple JDK versions installed, on locations where Gradle will > find them > - You may need -Pfreemarker.allowUnsignedReleaseBuild=true gradle command > line > option to building everything (not just the jar) > > The release artifacts are signed with the following key: > https://people.apache.org/keys/committer/ddekany.asc > > For convenience, we also provide binaries, which also need to be checked: > > https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.34-attempt-2/binaries/ > and Maven artifacts in the ASF Staging Repository: > > https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.34/ > > Please try out the package and vote! > > The vote is open for a minimum of 72 hours or until the necessary number of > votes (3 binding +1s) is reached. > > [ ] +1 Release this package as Apache FreeMarker 2.3.34 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Please add "(binding)" if your vote is binding. > > -- > Thanks, > Daniel Dekany >
