In FM2, you can cfg.getTemplate the *same* template file with
different encodings and with or without parsing.

What FM2 does there goes against common sense, causing a few tricky
parts in the implementation, and more importantly, it goes against
good practices. A template file has a certain encoding (charset), and
it doesn't make sense to get the same template file with different
encodings. Since 2.3.24 we have TemplateConfiguration-s to
(mass-)associate encoding to templates based on their source paths, so
different templates can have different encodings without this, and you
need no think about that when you simply get a template. I believe
that's the right way of doing this. (Note that as a consequence, we
wouldn't inherit "encoding" form the including template anymore, which
is good because that's also madness.)

Similarly, a template either uses FTL (parsed) or is just raw text to
insert (not parsed). So the same logic applies as with the encoding
parameter. (In this case the user should create a
TemplateConfiguration that specifies parsed=false and associate it to
*.txt or something like that.)

So I propose that we remove these parameters from getTemplate (and
#include), and instead tell the users to build on
TemplateConfiguration-s if they have templates with various charsets
or have some non-parsed templates.

-- 
Thanks,
 Daniel Dekany

Reply via email to