On Sun, Apr 9, 2017 at 6:36 AM, Daniel Dekany <[email protected]> wrote: > Sunday, April 9, 2017, 10:38:37 AM, Pradeep Murugesan wrote: > >> Hi, >> >> >> Moving this to a separate thread. >> >> >> So as the packages are renamed I will start with >> >> >> 1. Removing the Fallwizard . (try out SpringBoot) > > Yip (that, or for example Dropwizard). > >> 2. Optimising the DataModel > > Sure, after we have nothing in the way of deploying the app, except > that we don't have a yet VM... but then we have more to press the > issue at Infra. > > Though we will have to figure out how to continue there. One request > we have received from users is that we should support putting > date/time values into lists/maps, just as we support that for top > level variables. I don't think we can solve that elegantly if we stick > to JSON. (And then naturally, we should support having XML list items, > etc. Anything that's allowed on top-level.)
Agreed. Now I see it's better to have our own parser instead of sticking with JSON. The current format seems better especially with date/time and xml configuration. By the way, do we have a support for multi-line configuration for xml? For example, we could use """ or <<EOF like python or perl? That might be helpful for XML. Just my two cents, Woonsan > > BTW, there was some plan to allow defining multiple templates (with > names) so that people can experiment with #include and #import. > >> Also I have asked a CI question in the previous email which got >> lost. Posting the same in this email. >> >> 1. Do we need to configure travis CI for the online tester ? > > That would be nice to have. Most importantly, we should have that for > FreeMarker itself. > > -- > Thanks, > Daniel Dekany > >> Pradeep. >> >> >> ________________________________ >> From: Daniel Dekany <[email protected]> >> Sent: Friday, April 7, 2017 6:29 PM >> To: Woonsan Ko >> Subject: Re: Anyone volunteers for online-tester legal cleanup and other >> refactorings? >> >> Friday, April 7, 2017, 5:59:21 PM, Woonsan Ko wrote: >> >>> On Fri, Apr 7, 2017 at 10:21 AM, Pradeep Murugesan >>> <[email protected]> wrote: >>>> Hi, >>>> >>>> After that: >>>> >>>> - Get rid of the old Fallwizard dependency, as that version isn't >>>> available in well known repos. Certainly we should just use pure >>>> Dropwizard (or any other light weight "micro service" framework you >>>> >>>> feel like using). >>>> >>>> Do you think we can give a short at Spring boot to replace Fallwizard ? >>> >>> Spring boot sounds like a good idea to me. >> >> Assuming it doesn't have significant memory overhead compared to >> Dropwizard, it's fine. >> >>> By the way, regarding the data model parsing, I'm just wondering if we >>> can simplify the parsing code (DataModelParser.java) by accepting only >>> a JSON string like the following example: >>> >>> { >>> someString: "Some value", >>> someNumber: 3.14, >>> someBoolean: true >>> someDatetime: "2014-02-28T18:50Z", >>> someList: ["JSON", "syntax", 1, 2, 3 ], >>> someMap: { "JSON syntax": true, "nestedList": [1, 2, 3] } >>> someXML: "<example x='1'>text</example>" >>> } >>> >>> Jackson support ALLOW_UNQUOTED_FIELD_NAMES option and good type >>> handling of values... >> >> The question remains if what should we do with date/time values (which >> JSON doesn't have), XML values, as there's no JSON syntax for them. >> >> Also JSON is less convenient, as it doesn't support multi-line strings >> and XML as we do, and that's especially handy for XML. You don't even >> have to quote XML with the current syntax, which makes copy-pasting >> snippets much easier. Copy-pasting is a design goal here. >> >> BTW, right now we have the issue that you can't use date/time or XML >> inside lists and maps, exactly because those use JSON syntax. So I'm >> rather on the side of moving away from JSON. It's too simplistic by >> design, and we have no power to extend it. And writing out own parsers >> is easy, so, why not... >> >>> Just my two cents, >>> >>> Woonsan >>> >>>> Also should we think about using Travis CI for continuous integration or >>>> you have any other ideas ? >>>> >>>> Pradeep. >>>> ________________________________ >>>> From: Daniel Dekany <[email protected]> >>>> Sent: Saturday, April 1, 2017 10:09 PM >>>> To: [email protected] >>>> Subject: Anyone volunteers for online-tester legal cleanup and other >>>> refactorings? >>>> >>>> We have just received the source code of >>>> http://freemarker-online.kenshoo.com/ from Kenshoo, as a contribution >> [https://camo.githubusercontent.com/a6677b08c955af8400f44c6298f40e7d19cc5b2d/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f677261795f3664366436642e706e67]<http://freemarker-online.kenshoo.com/> >> >> Online FreeMarker Template >> Tester<http://freemarker-online.kenshoo.com/> >> freemarker-online.kenshoo.com >> Note: This syntax is specific to this online service; normally, you >> just have Java objects as data-model. >> >> >> >>>> to the FreeMarker project. Here's the Git repo: >>>> >>>> https://git-wip-us.apache.org/repos/asf?p=incubator-freemarker-online-tester.git >>>> https://github.com/apache/incubator-freemarker-online-tester >>>> >>>> Anyone wants to take care of some (or all) of these tasks: >>>> >>>> The first thing to do is the legal cleanup: >>>> - Change license headers (such as it can't contain "Copyright 2014 >>>> Kenshoo.com") >>>> - Change the package from com.kenshoo.freemarker to >>>> org.apache.freemarker.onlinetester (or something like that) >>>> - Update LICENSE (and NOTICES if needed) with any extra intellectual >>>> property related information needed. >>>> >>>> After that: >>>> - Get rid of the old Fallwizard dependency, as that version isn't >>>> available in well known repos. Certainly we should just use pure >>>> Dropwizard (or any other light weight "micro service" framework you >>>> feel like using). >>>> >>>> And finally we should continue pushing >>>> https://issues.apache.org/jira/browse/INFRA-13246 "Create a demo VM >> [INFRA-13246] Create a demo VM for the Freemarker project >> ...<https://issues.apache.org/jira/browse/INFRA-13246> >> issues.apache.org >> The Freemarker team (incubating) would like to promote their >> project more. The site http://freemarker-online.kenshoo.com/ >> provides a way to test Freemarker code online. >> >> >> >>>> [INFRA-13246] Create a demo VM for the Freemarker project >>>> ...<https://issues.apache.org/jira/browse/INFRA-13246> >> [INFRA-13246] Create a demo VM for the Freemarker project >> ...<https://issues.apache.org/jira/browse/INFRA-13246> >> issues.apache.org >> The Freemarker team (incubating) would like to promote their >> project more. The site http://freemarker-online.kenshoo.com/ >> provides a way to test Freemarker code online. >> >> >> >>>> issues.apache.org >>>> The Freemarker team (incubating) would like to promote their project more. >>>> The site http://freemarker-online.kenshoo.com/ provides a way to test >>>> Freemarker code online. >> [https://camo.githubusercontent.com/a6677b08c955af8400f44c6298f40e7d19cc5b2d/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f677261795f3664366436642e706e67]<http://freemarker-online.kenshoo.com/> >> >> Online FreeMarker Template >> Tester<http://freemarker-online.kenshoo.com/> >> freemarker-online.kenshoo.com >> Note: This syntax is specific to this online service; normally, you >> just have Java objects as data-model. >> >> >> >>>> >>>> >>>> >>>> for the Freemarker project". >>>> >>>> -- >>>> Thanks, >>>> Daniel Dekany >>>> >>> >> >> -- >> Thanks, >> Daniel Dekany >> >
