Thursday, April 13, 2017, 2:32:17 PM, Daniel Dekany wrote: > Thursday, April 13, 2017, 12:12:32 PM, Pradeep Murugesan wrote: > >> ok.. >> >> >> So should this (ant dist) be also part of our build in Travis ? > > Probably not. Building distros can be tricky, so it might not worths > complicating matters with that. > > However, the boot class path and JDK version check at the beginning of > the "dist" task should be ran. Of course, only if and when we can > solve compiling against multiple rt.jar-s.
Also, it should run the "javadoc" task, so that the build fails if we have broken JavaDoc comments. >> Will we face any situation where the "ant" passes and while making >> releases the "ant dist" fails. > > Hopefully such problems will be rare and easily solvable for the > release engineer. > >> For example in this change, moving the README to md the ant task >> worked and built the jar successfully, where as the "ant dist" >> failed stating the README does not exists since I have changed the file name >> to README.md >> >> Pradeep. >> >> >> >> ________________________________ >> From: Daniel Dekany <[email protected]> >> Sent: Thursday, April 13, 2017 11:43:22 AM >> To: Pradeep Murugesan >> Subject: Re: Freemarker Readme to markdown. >> >> Thursday, April 13, 2017, 10:58:11 AM, Pradeep Murugesan wrote: >> >>> Hi, >>> >>> >>> after renaming the readme to md (also changed in the build.xml). >>> I tried running the ant dist to verify. Got the following error. Do >>> we have instructions on how to dist already somewhere ? >> >> Not one that details `ant dist` specifically. (But >> http://freemarker.org/committer-howto.html#making-releases can be >> extended with help out with common problems.) >> >>> I searched in the readme itself and in the freemarker site, but found >>> nothing. >>> >>> >>> ubating-bin.tar.gz >>> [delete] Deleting: >>> /Users/pmurugesan/personal/git/apache/freemarker/incubator-freemarker/build/dist/apache-freemarker-gae-2.3.26-incubating-bin.tar >>> [echo] Signing >>> "build/dist/apache-freemarker-gae-2.3.26-incubating-bin.tar.gz"... >>> [exec] gpg: no default secret key: No secret key >>> [exec] gpg: signing failed: No secret key >> >> Well, is gpg right? Do you have a PGP signature? (I do have, and for >> me it automatically signs with that.) >> >>> BUILD FAILED >>> /Users/pmurugesan/personal/git/apache/freemarker/incubator-freemarker/build.xml:656: >>> The following error occurred while executing this line: >>> /Users/pmurugesan/personal/git/apache/freemarker/incubator-freemarker/build.xml:711: >>> The following error occurred while executing this line: >>> /Users/pmurugesan/personal/git/apache/freemarker/incubator-freemarker/build.xml:772: >>> exec returned: 2 >>> >>> Total time: 38 seconds >>> >>> >>> Kindly clarify. >>> >>> >>> Pradeep. >>> >>> ________________________________ >>> From: Daniel Dekany <[email protected]> >>> Sent: Thursday, April 13, 2017 10:05:27 AM >>> To: Pradeep Murugesan >>> Subject: Re: Freemarker Readme to markdown. >>> >>> Thursday, April 13, 2017, 9:52:42 AM, Pradeep Murugesan wrote: >>> >>>> Hi, >>>> >>>> >>>> I could see that our freemarker read me has something like >>>> >>>> >>>> Apache FreeMarker {version} >>>> >>>> >>>> Is the {version} intentional or should be replaced with appropriate >>>> version name (eg. 2.3-gae). >>> >>> It's a pattern replaced by the actual version when you build a >>> distributions (`ant dist`). >>> >>>> >>>> like >>>> >>>> >>>> >>>> Apache FreeMarker 2.3-gae >>>> >>>> >>>> Pradeep. >>> >>> -- >>> Thanks, >>> Daniel Dekany >>> >> >> -- >> Thanks, >> Daniel Dekany >> > -- Thanks, Daniel Dekany
