Hi!

The pseudo-globbing-patterns fsvs uses to ignore files are not anchored to 
the end of the string when they are compiled into PCR expressions.

This causes a pattern like "./**.o" not only to ignore aall object files, 
as at least I had expected, but any file which contains the 
substring ".o" somewhere in its full file or directory name. ie. it will 
exclude all OpenDocument files and everything inside the 
directory "my.o.my", for example.

As the manual does not mention this at all and there is no privision to 
achor a globbing paattern explicitely, I think this is a bug.

I think something like the attached patch could fix that, but 
unfortunately I could not even compile test it as for some reason fsvs 
does not like to build in my system at the moment. Running Debian SID I 
probably messed something up recently... :-/

Greetings,

  Gunter


--- fsvs-1.0.13/src/ignore.c    2006-08-22 19:30:52.000000000 +0200
+++ fsvs-1.0.13_mod/src/ignore.c        2006-10-10 23:45:58.000000000 
+0200
@@ -159,9 +159,10 @@
                                        "not enough space in buffer");
                } while (*src);

+               *dest++='$';
                *dest=0;
                /* return unused space */
-               buffer=realloc(buffer, dest-buffer+2);
+               buffer=realloc(buffer, dest-buffer+3);
                STOPIF_ENOMEM(!buffer);
                ignore->compare_string=buffer;
                dest=buffer;

-- 
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
"The thing is that Mr. Dibbler can even sell sausages to people who have 
bought them off him *before*."        -- (Terry Pratchett, Moving 
Pictures)
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+                   PGP-verschlüsselte Mails bevorzugt!                 +
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Attachment: pgpnpvRiiWfym.pgp
Description: PGP signature

Reply via email to