I took a quick look, and ran it on my system - and it seems to work fine.
Here are two patches for the cleanup part, and renaming the URLs file - both
untested.
What's left to do is the rewriting of the ignore patterns.
And I'd propose changing your progress messages to have a "# " in front,
the "echo <cmd>" statements to "$DEBUG <cmd>", and setting $DEBUG to "echo"
or "", depending on some commandline parameter.
Then people can take a look what would happen, and possibly even redirect the
output into a file to be used with "bash <filename>" directly.
Furthermore I'd suggest to change the PREFIX_ calculation to something like
this:
# Only the path below $FSVS_WAA
find $FSVS_WAA -type f -printf "%P\n" |
# Do streaming, as this could be several thousand files.
while IFS=/ read PREFIX_ONE PREFIX_TWO SUB_PATH
do
j=$FSVS_WAA/$PREFIX_ONE/$PREFIX_TWO/$SUB_PATH
although I have to admit I don't quite understand why PREFIX_ONE etc. are
really used - you do a "mkdir -p", so the levels in the middle are created
anyway.
If you don't need them, you could replace that with
find ... | while read j
If it gets a "help" or "usage" parameter (which prints some text), and
possibly a "doitreally" (which sets DEBUG to "") ... that would make it
nearly perfect, only a fine ASCII-art animation could be displayed while
doing the work ;-)
Nice work; good that you're including some documentation inline.
Gunnar, *thank you very much*. You'll receive (at least) a honorable mention;
maybe you'll even have a free wish (feature-wise) - and for the moment I'll
just assume that you'd like http/https authentication running, so I'll try to
get that working (although I have no real test environment).
Regards,
Phil
--
Versioning your /etc, /home or even your whole installation?
Try fsvs (fsvs.tigris.org)!
------------------------------------------------------
http://fsvs.tigris.org/ds/viewMessage.do?dsForumId=3923&dsMessageId=983511
To unsubscribe from this discussion, e-mail: [[email protected]].
