[ 
https://issues.apache.org/jira/browse/GEARPUMP-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259495#comment-15259495
 ] 

ASF GitHub Bot commented on GEARPUMP-41:
----------------------------------------

Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/4#discussion_r61200851
  
    --- Diff: core/src/main/scala/io/gearpump/cluster/ClusterConfig.scala ---
    @@ -142,7 +142,7 @@ object ClusterConfig {
     
         if (!akka.util.Helpers.isWindows) {
     
    -      // Change the akka.scheduler.tick-duration to 10ms for Linux or Mac
    +      // Change the akka.scheduler.tick-duration to 1 ms for Linux or Mac
    --- End diff --
    
    That's different situations.
    When the cluster config is loaded, it will check the environment and 
```akka.scheduler.tick-duration``` to make sure the ActorSystem can be launched 
correctly.
    
    However, when launching an application, the Config of Executor's ActorSytem 
is composed of Worker's cluster config and application's config, and Worker's 
```akka.scheduler.tick-duration``` could be overwrote by a wrong value. So 
another check here is needed.


> property akka.scheduler.tick-duration will be override and potentially go 
> wrong on Windows
> ------------------------------------------------------------------------------------------
>
>                 Key: GEARPUMP-41
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-41
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: daemon
>    Affects Versions: 0.8.0
>            Reporter: Huafeng Wang
>            Assignee: Huafeng Wang
>         Attachments: GEARPUMP-41.patch
>
>
> How to reproduce:
> 1. Launch Master and Dashboard on a Linux machine.
> 2. Launch a Worker on a Windows machine.
> 3. Submit an application from dashboard.
> Then the application will fail to launch Executor on Windows because the 
> property akka.scheduler.tick-duration is override by the value from Linux 
> Machine, which by default is 1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to