Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/31#discussion_r65495393
--- Diff:
daemon/src/main/scala/org/apache/gearpump/cluster/master/AppManager.scala ---
@@ -310,22 +320,20 @@ private[cluster] class AppManager(kvService:
ActorRef, launcher: AppMasterLaunch
case class RecoverApplication(applicationStatus: ApplicationState)
private def cleanApplicationData(appId: Int): Unit = {
- // Add the dead app to dead appMaster
- appMasterRegistry.get(appId).foreach { pair =>
- val (appMasterActor, info) = pair
- deadAppMasters += appId -> (appMasterActor, info.copy(
- finishTime = System.currentTimeMillis()))
- }
-
- appMasterRegistry -= appId
+ // Add the dead app to dead appMasters
+ deadAppMasters += appId
--- End diff --
When the application is down, you don't update its finish time. You can see
the dashboard missed that info.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
